From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] POWERPC: Added RTC support for mpc8313RDB and utilize "clock-frequency"
Date: Tue, 17 Jul 2007 21:58:22 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.60.0707172154190.3535@poirot.grange> (raw)
In-Reply-To: <20070717214824.04db9e88@vitb.ru.mvista.com>
On Tue, 17 Jul 2007, Vitaly Bordug wrote:
> > Please don't do this; drivers/i2c/chips/ds1337.c is deprecated. You
> > should be using the RTC-class driver in drivers/rtc/rtc-ds1307.c, which
> > has a non-device-specific API that can be used.
> >
> > The ppc_md RTC functions should really just go away, though -- setting
> > the clock on bootup can be done by generic code, and periodically
> > updating the RTC when using NTP can be done from userspace.
>
> If those ppc_md hookups would be declared deprecated, there's no much sense in the upper,
> apparently. But I am not sure they will be... I'm inclined to let this patch floating since
> interacting with rtc class from within BSP code just does not worth it.
Exactly! Don't interact with it. Just leave it alone. No need to re-write
[sg]et_rtc_time, bother with setting system time on bootup... Just let the
rtc driver and framework do it for you.
Thanks
Guennadi
---
Guennadi Liakhovetski
prev parent reply other threads:[~2007-07-17 19:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-17 0:49 [PATCH] POWERPC: Added RTC support for mpc8313RDB and utilize "clock-frequency" Vitaly Bordug
2007-07-17 16:36 ` Scott Wood
2007-07-17 17:48 ` Vitaly Bordug
2007-07-17 17:53 ` Scott Wood
2007-07-17 18:12 ` Jon Loeliger
2007-07-17 19:58 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.60.0707172154190.3535@poirot.grange \
--to=g.liakhovetski@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).