From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by ozlabs.org (Postfix) with SMTP id CE8C0DDE30 for ; Wed, 18 Jul 2007 05:58:26 +1000 (EST) Date: Tue, 17 Jul 2007 21:58:22 +0200 (CEST) From: Guennadi Liakhovetski To: Vitaly Bordug Subject: Re: [PATCH] POWERPC: Added RTC support for mpc8313RDB and utilize "clock-frequency" In-Reply-To: <20070717214824.04db9e88@vitb.ru.mvista.com> Message-ID: References: <20070717004913.21682.50282.stgit@localhost.localdomain> <20070717163645.GB7347@ld0162-tx32.am.freescale.net> <20070717214824.04db9e88@vitb.ru.mvista.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linuxppc-dev , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 17 Jul 2007, Vitaly Bordug wrote: > > Please don't do this; drivers/i2c/chips/ds1337.c is deprecated. You > > should be using the RTC-class driver in drivers/rtc/rtc-ds1307.c, which > > has a non-device-specific API that can be used. > > > > The ppc_md RTC functions should really just go away, though -- setting > > the clock on bootup can be done by generic code, and periodically > > updating the RTC when using NTP can be done from userspace. > > If those ppc_md hookups would be declared deprecated, there's no much sense in the upper, > apparently. But I am not sure they will be... I'm inclined to let this patch floating since > interacting with rtc class from within BSP code just does not worth it. Exactly! Don't interact with it. Just leave it alone. No need to re-write [sg]et_rtc_time, bother with setting system time on bootup... Just let the rtc driver and framework do it for you. Thanks Guennadi --- Guennadi Liakhovetski