From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>,
Domen Puncer <domen.puncer@telargo.com>,
i2c@lm-sensors.org
Subject: Re: [PATCH] i2c-mpc: don't disable I2C module on stop condition.
Date: Wed, 8 Aug 2007 20:33:52 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.60.0708082001380.6767@poirot.grange> (raw)
In-Reply-To: <20070808191913.3e6bb0e6@hyperion.delvare>
On Wed, 8 Aug 2007, Jean Delvare wrote:
> Hi Domen,
>
> On Tue, 24 Jul 2007 07:14:31 +0200, Domen Puncer wrote:
> > Disabling module on stop doesn't work on some CPUs (ie. mpc8241,
> > as reported by Guennadi Liakhovetski), so remove that.
> >
> > Disable I2C module on errors/interrupts to prevent it from
> > locking up on mpc5200b.
> >
> >
> > Signed-off-by: Domen Puncer <domen.puncer@telargo.com>
> > ---
> > Hi!
> >
> > So I fixed i2c on one board, and broke it on another :-(
> > This patch works on both Guennadi's and mine (hey, it might break
> > a third one!).
> > Jean, can you please push this, if there are no objections
> > and "doesn't work for me" reports.
>
> Queued for 2.6.23-rc3, thanks. Guennadi, can you please confirm that
> this patch fixes your problem?
Yes, it does. Also tested with i2c bus debugging on and with interrupting
hwclock, thereby messages
I2C: Interrupted
come, but the controller stays functional. Looks good so far:-)
Acked-by: G. Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
---
Guennadi Liakhovetski
prev parent reply other threads:[~2007-08-08 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-09 7:19 [PATCH] i2c-mpc: work around missing-9th-clock-pulse bug Domen Puncer
2007-07-09 15:53 ` Grant Likely
2007-07-10 6:17 ` Domen Puncer
2007-07-10 6:22 ` Grant Likely
2007-07-10 12:40 ` Jean Delvare
2007-07-11 5:49 ` Domen Puncer
2007-07-11 6:03 ` Grant Likely
2007-07-11 6:33 ` Domen Puncer
2007-07-11 11:40 ` Jean Delvare
2007-07-21 0:03 ` [i2c] " Guennadi Liakhovetski
2007-07-24 5:14 ` [PATCH] i2c-mpc: don't disable I2C module on stop condition Domen Puncer
2007-08-08 17:19 ` Jean Delvare
2007-08-08 18:33 ` Guennadi Liakhovetski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.60.0708082001380.6767@poirot.grange \
--to=g.liakhovetski@gmx.de \
--cc=domen.puncer@telargo.com \
--cc=i2c@lm-sensors.org \
--cc=khali@linux-fr.org \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox