Re: [PATCH] Mark prop unused in early_init_dt_scan_chosen().

[Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>]

On Wed, 9 May 2007, Kumar Gala wrote:
> On Tue, 8 May 2007, Scott Wood wrote:
> > The prop variable is only referenced when initrd support is
> > turned on.
> >
> > Signed-off-by: Scott Wood <scottwood@freescale.com>
> > ---
> >  arch/powerpc/kernel/prom.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
> > index caef555..6705459 100644
> > --- a/arch/powerpc/kernel/prom.c
> > +++ b/arch/powerpc/kernel/prom.c
> > @@ -720,7 +720,7 @@ static int __init early_init_dt_scan_chosen(unsigned long node,
> >  					    const char *uname, int depth, void *data)
> >  {
> >  	unsigned long *lprop;
> > -	u32 *prop;
> > +	u32 __attribute__((unused)) *prop;
> 
> is this the desired way to remove warnings related to CONFIG_ options?  I
> know in the past we'd wrap it with a #ifdef CONFIG_FOO

Exactly my thought.

Another advantage of #ifdef CONFIG_FOO is that if the actual code that uses it
goes away, we'll get a warning again. Else in the end we'll be stuck with
zillions of unused variables that don't cause warnings...

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium