From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] powerpc: Fixup hard_irq_disable semantics
Date: Thu, 10 May 2007 09:44:18 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0705100942590.32241@pademelon.sonytel.be> (raw)
In-Reply-To: <20070510052620.EC36DDDF92@ozlabs.org>
On Thu, 10 May 2007, Benjamin Herrenschmidt wrote:
> This patch renames the raw hard_irq_{enable,disable} into
> __hard_irq_{enable,disable} and introduces a higher level
> hard_irq_disable() function that can be used by any code
> to enforce that IRQs are fully disabled, not only lazy
> disabled.
Why did you rename hard_irq_enable() too?
Isn't it more logical to have high-level hard_irq_disable() and
hard_irq_enable(), and a special low-level __hard_irq_disable()?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
next prev parent reply other threads:[~2007-05-10 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 5:25 [PATCH 1/3] powerpc: Fixup hard_irq_disable semantics Benjamin Herrenschmidt
2007-05-10 7:44 ` Geert Uytterhoeven [this message]
2007-05-10 8:44 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0705100942590.32241@pademelon.sonytel.be \
--to=geert.uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).