From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: asm-ppc header issues when building ARCH=powerpc
Date: Thu, 23 Aug 2007 11:47:20 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.62.0708231146200.29327@pademelon.sonytel.be> (raw)
In-Reply-To: <F19C9986-9E53-47F3-835D-C93DA9C3ADED@kernel.crashing.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2269 bytes --]
On Wed, 22 Aug 2007, Kumar Gala wrote:
> On Aug 22, 2007, at 10:33 PM, David Gibson wrote:
> > On Wed, Aug 22, 2007 at 10:33:55PM -0500, Kumar Gala wrote:
> >> On Aug 22, 2007, at 10:19 AM, Kumar Gala wrote:
> >>> I was wondering if I could get your help with looking at the
> >>> following lists and determining if we have an issue or not related
> >>> the following files:
> >>>
> >>> Getting some classification on these would be good. Possibly
> >>> classifications, doesn't build in ARCH=powerpc, remove include, real
> >>> issue, etc.
> >>>
> >> My analysis of <asm/bootinfo.h> usage:
> >>
> >> ./drivers/macintosh/adb-iop.c:#include <asm/bootinfo.h> remove
> >> ./drivers/char/vme_scc.c:#include <asm/bootinfo.h> 68k only
> >> ./drivers/char/serial167.c:#include <asm/bootinfo.h> 68k only
> >> ./drivers/serial/dz.c:#include <asm/bootinfo.h> decstation
> >> ./drivers/mtd/devices/ms02-nv.c:#include <asm/bootinfo.h> decstation
> >> ./drivers/net/macsonic.c:#include <asm/bootinfo.h> 68k
> >> ./drivers/net/jazzsonic.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/pmag-aa-fb.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/maxinefb.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/logo/logo.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/macfb.c:#include <asm/bootinfo.h> 68k
> >> ./drivers/video/valkyriefb.c:#include <asm/bootinfo.h> 68k
> >
> > Uh.. I'm pretty sure valkyriefb.c is for (old) PowerMacs, not 68k.
>
> It appears to be both. If you look at the include its protected by a
> #ifdef CONFIG_MAC which we is only defined on m68k.
Indeed, drivers/video/Kconfig says it depends on MAC || (PPC_PMAC && PPC32)
With kind regards,
Geert Uytterhoeven
Software Architect
Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
Phone: +32 (0)2 700 8453
Fax: +32 (0)2 700 8622
E-mail: Geert.Uytterhoeven@sonycom.com
Internet: http://www.sony-europe.com/
Sony Network and Software Technology Center Europe
A division of Sony Service Centre (Europe) N.V.
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium
VAT BE 0413.825.160 · RPR Brussels
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619
next prev parent reply other threads:[~2007-08-23 9:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 15:19 asm-ppc header issues when building ARCH=powerpc Kumar Gala
2007-08-22 16:01 ` Scott Wood
2007-08-22 19:30 ` Josh Boyer
2007-08-23 2:49 ` David Gibson
2007-08-23 3:09 ` Kumar Gala
2007-08-23 2:47 ` David Gibson
2007-08-23 3:22 ` Kumar Gala
2007-08-23 17:33 ` Scott Wood
2007-08-23 18:00 ` Kumar Gala
2007-08-23 3:33 ` Kumar Gala
2007-08-23 3:33 ` David Gibson
2007-08-23 4:16 ` Kumar Gala
2007-08-23 9:47 ` Geert Uytterhoeven [this message]
2007-08-23 18:56 ` Brad Boyer
2007-08-24 7:10 ` Geert Uytterhoeven
2007-08-24 7:24 ` Kumar Gala
2007-08-24 7:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0708231146200.29327@pademelon.sonytel.be \
--to=geert.uytterhoeven@sonycom.com \
--cc=david@gibson.dropbear.id.au \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).