linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc: Make isa_mem_base common to 32 and 64 bits
Date: Tue, 13 Nov 2007 09:18:11 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.62.0711130917350.31003@pademelon.sonytel.be> (raw)
In-Reply-To: <20071113044429.461B1DDE2E@ozlabs.org>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1828 bytes --]

On Tue, 13 Nov 2007, Benjamin Herrenschmidt wrote:
> This defines isa_mem_base on both 32 and 64 bits (it used to be 32 bits
> only). This avoids a few ifdef's in later patches and potentially can
> allow support for VGA text mode on 64 bits powerpc.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> 
> Small cleanup pre-requisite for my next patch
> 
>  arch/powerpc/kernel/pci-common.c |    4 ++++
>  arch/powerpc/kernel/pci_32.c     |    1 -
>  include/asm-powerpc/io.h         |    5 +++--
>  3 files changed, 7 insertions(+), 3 deletions(-)
> 
> Index: linux-work/arch/powerpc/kernel/pci-common.c
> ===================================================================
> --- linux-work.orig/arch/powerpc/kernel/pci-common.c	2007-11-13 14:11:11.000000000 +1100
> +++ linux-work/arch/powerpc/kernel/pci-common.c	2007-11-13 14:15:43.000000000 +1100
> @@ -52,6 +52,10 @@ int global_phb_number;		/* Global phb co
>  
>  extern struct list_head hose_list;
>  
> +/* ISA Memory physical address (or 0 if none) */
                                   ^^^^^^^^^^^^
> +resource_size_t isa_mem_base    = 0;

Let's hope this doesn't confuse too many people, as 0 is the valid value on
legacy PC hardware ;-)

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven@sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619

  reply	other threads:[~2007-11-13  8:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-13  4:43 [PATCH 1/2] powerpc: Make isa_mem_base common to 32 and 64 bits Benjamin Herrenschmidt
2007-11-13  8:18 ` Geert Uytterhoeven [this message]
2007-11-13  9:55   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0711130917350.31003@pademelon.sonytel.be \
    --to=geert.uytterhoeven@sonycom.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).