From: Christoph Lameter <clameter@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-mm@kvack.org, ppc-dev <linuxppc-dev@ozlabs.org>,
paulus@samba.org, LKML <linux-kernel@vger.kernel.org>,
ak@suse.de
Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages
Date: Thu, 26 Oct 2006 12:00:30 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610261158130.2802@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20061026133305.b0db54e6.sfr@canb.auug.org.au>
On Thu, 26 Oct 2006, Stephen Rothwell wrote:
> This is needed on bigendian 64bit architectures. The obvious way to do
> this (taking the other compat_ routines in this file as examples) is to
> use compat_alloc_user_space and copy the bitmasks back there, however you
> cannot call compat_alloc_user_space twice for a single system call and
> this method saves two copies of the bitmasks.
Well this means also that sys_mbind and sys_set_mempolicy are also
broken because these functions also use get_nodes().
Fixing get_nodes() to do the proper thing would fix all of these
without having to touch sys_migrate_pages or creating a compat_ function
(which usually is placed in kernel/compat.c)
next prev parent reply other threads:[~2006-10-26 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 3:26 [PATCH 1/3] Constify compat_get_bitmap argument Stephen Rothwell
2006-10-26 3:33 ` [PATCH 2/3] Create compat_sys_migrate_pages Stephen Rothwell
2006-10-26 3:34 ` [PATCH 3/3] [POWERPC] Wire up sys_migrate_pages Stephen Rothwell
2006-10-26 3:57 ` [PATCH 2/3] Create compat_sys_migrate_pages Stephen Rothwell
2006-10-26 23:04 ` Arnd Bergmann
2006-10-26 19:00 ` Christoph Lameter [this message]
2006-10-27 0:28 ` Stephen Rothwell
2006-10-27 13:24 ` Christoph Lameter
2006-10-30 5:29 ` Benjamin Herrenschmidt
2006-10-26 23:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610261158130.2802@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).