linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@osdl.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Please pull powerpc.git 'merge' branch
Date: Tue, 21 Nov 2006 18:47:44 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0611211843010.3338@woody.osdl.org> (raw)
In-Reply-To: <17763.46950.961979.77987@cargo.ozlabs.ibm.com>



On Wed, 22 Nov 2006, Paul Mackerras wrote:
>
>     [POWERPC] Revert "[POWERPC] Add powerpc get/set_rtc_time interface to new generic rtc class"
>     
>     This reverts commit 7a69af63e788a324d162201a0b23df41bcf158dd.
>     
>     As advised by David Brownell:
>     
>     http://marc.theaimsgroup.com/?l=linux-kernel&m=116387226902131&w=2

Btw, when doing a web-pointer like this, _please_ don't just leave it 
hanging like that.

For one thing, there's no guarantee that the web-server will continue to 
exist, or not move around the data. And even _if_ the data still exists 
and at that address, when looking at bugs of old history it's really 
irritating to have to fire up a web browser - not to mention that maybe 
you're on an airplane or other place without internet access. Git works 
fine disconnected.

So the rule is:

 - it's perfectly _fine_ to point to web addresses for "further 
   information" (especially things like bugzilla, of course)

 - but the commit message also has to stand on its own, even _without_ the 
   pointer. So at least add a sentence about why - even if the web pointer 
   would explain it more.

So even if you just say something trivial like

	As pointed out by David Brownell, that commit was just a total 
	thinko, and could never work.

at least it doesn't leave the commit message _totally_ without any 
context.

		Linus

  reply	other threads:[~2006-11-22  2:47 UTC|newest]

Thread overview: 146+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22  2:35 Please pull powerpc.git 'merge' branch Paul Mackerras
2006-11-22  2:47 ` Linus Torvalds [this message]
2006-11-22 21:40   ` Paul Mackerras
2006-11-22 21:53     ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2008-04-03 11:33 Please pull powerpc.git merge branch Paul Mackerras
2008-03-28 12:35 Paul Mackerras
2008-03-28 22:06 ` Bartlomiej Sieka
2008-04-01 23:12   ` Paul Mackerras
2008-04-02  4:27     ` Grant Likely
2008-04-02 14:32     ` Bartlomiej Sieka
2008-03-27 23:08 Paul Mackerras
2008-03-25  3:32 Paul Mackerras
2008-03-24  8:05 Paul Mackerras
2008-03-20  0:43 Paul Mackerras
2008-03-12 23:51 Paul Mackerras
2008-03-03 11:41 Paul Mackerras
2008-03-03 15:44 ` Grant Likely
2008-02-20  3:46 Paul Mackerras
2008-02-21 12:15 ` Paul Mackerras
2008-02-14 22:00 Paul Mackerras
2008-02-15 22:43 ` Josh Boyer
2008-01-15 10:19 Paul Mackerras
2008-01-12  0:09 Paul Mackerras
2008-01-02  5:21 Paul Mackerras
2007-12-28  9:28 Paul Mackerras
2007-12-28 21:53 ` Geoff Levand
2007-12-31  1:40   ` Paul Mackerras
2007-12-31 16:12     ` Arnd Bergmann
2008-01-02  4:39       ` Jeremy Kerr
2007-12-17  6:00 Paul Mackerras
2007-12-07  1:04 Paul Mackerras
2007-12-06 12:01 Paul Mackerras
2007-12-02 23:12 Paul Mackerras
2007-12-03  0:25 ` Josh Boyer
2007-11-26 22:09 Paul Mackerras
2007-11-20  8:38 Paul Mackerras
2007-11-13 11:11 Paul Mackerras
2007-11-08  9:54 Paul Mackerras
2007-10-23  4:21 Paul Mackerras
2007-10-17 12:49 Paul Mackerras
2007-10-17 13:31 ` Josh Boyer
2007-10-02  3:15 Paul Mackerras
2007-09-25 11:40 Paul Mackerras
2007-09-25 12:43 ` Kumar Gala
2007-09-25 12:52   ` Paul Mackerras
2007-09-26 11:33 ` Paul Mackerras
2007-09-19 12:38 Paul Mackerras
2007-09-10 19:13 Paul Mackerras
2007-08-30 11:49 Paul Mackerras
2007-08-30 14:32 ` Kumar Gala
2007-08-26 23:57 Paul Mackerras
2007-08-17  0:51 Paul Mackerras
2007-08-15 11:41 Paul Mackerras
2007-08-10 12:20 Paul Mackerras
2007-08-03 10:32 Paul Mackerras
2007-08-06  5:57 ` Zhang Wei-r63237
2007-08-06 13:57   ` Kumar Gala
2007-08-07  1:06     ` Michael Ellerman
2007-08-07  2:57       ` Zang Roy-r61911
2007-08-07  3:18         ` Michael Ellerman
2007-08-07  3:31           ` Zhang Wei-r63237
2007-07-26 12:10 Paul Mackerras
2007-07-22 12:56 Paul Mackerras
2007-07-11  4:46 Paul Mackerras
2007-07-05  1:45 Paul Mackerras
2007-07-02  4:25 Paul Mackerras
2007-07-02  6:04 ` Paul Mackerras
2007-06-26 10:08 Paul Mackerras
2007-06-20 12:46 Paul Mackerras
2007-06-19  5:39 Paul Mackerras
2007-06-15  5:00 Paul Mackerras
2007-04-11 22:29 Paul Mackerras
2007-03-28 23:51 Paul Mackerras
2007-03-22  4:31 Paul Mackerras
2007-03-13  0:47 Paul Mackerras
2007-03-08  4:01 Paul Mackerras
2007-03-09 21:08 ` Paul Mackerras
2007-03-09 23:31   ` Arnd Bergmann
2007-01-27 23:08 Please pull powerpc.git 'merge' branch Paul Mackerras
2007-01-27 23:15 ` Paul Mackerras
2007-01-22 11:50 Paul Mackerras
2007-01-09  9:45 Paul Mackerras
2006-12-20 10:23 Paul Mackerras
2006-12-20 10:52 ` Benjamin Herrenschmidt
2006-12-20 11:15   ` Arnd Bergmann
2006-12-20 11:18     ` Benjamin Herrenschmidt
2006-11-16  2:19 Paul Mackerras
2006-11-11 11:32 Paul Mackerras
2006-11-01  7:30 Paul Mackerras
2006-10-25  6:26 Paul Mackerras
2006-10-25 14:09 ` Kumar Gala
2006-10-25 21:37   ` Paul Mackerras
2006-10-25 22:02     ` Kumar Gala
2006-10-25 14:22 ` Olof Johansson
2006-10-25 21:34   ` Paul Mackerras
2006-10-25 22:32     ` Olof Johansson
2006-10-17  4:02 Paul Mackerras
2006-10-10  5:31 Paul Mackerras
2006-10-07 12:33 Paul Mackerras
2006-09-13 12:47 Paul Mackerras
2006-09-14 19:14 ` Linus Torvalds
2006-09-14 22:55   ` Paul Mackerras
2006-09-14 23:36     ` Linus Torvalds
2006-09-15 19:59       ` Linus Torvalds
2006-08-31  4:34 Paul Mackerras
2006-08-31  4:49 ` Linus Torvalds
2006-09-03 19:16 ` Linus Torvalds
2006-09-03 19:23   ` Sergei Shtylyov
2006-09-03 19:29     ` Linus Torvalds
2006-09-03 20:41       ` Segher Boessenkool
2006-09-03 21:15   ` Benjamin Herrenschmidt
2006-09-03 21:33     ` Linus Torvalds
2006-09-03 21:54       ` Benjamin Herrenschmidt
2006-08-24  0:44 Paul Mackerras
     [not found] ` <20060824010508.GA17848@suse.de>
2006-08-24  4:02   ` Paul Mackerras
2006-08-24  4:10     ` Greg KH
2006-08-24 13:22       ` Jon Loeliger
2006-08-24 13:33         ` Kumar Gala
2006-08-18  2:10 Paul Mackerras
2006-08-18 14:15 ` Matt Porter
2006-08-18 16:20 ` Greg KH
2006-07-31  5:37 please " Paul Mackerras
2006-07-31 20:41 ` Linus Torvalds
2006-06-21  8:21 Paul Mackerras
2006-06-21 12:45 ` Kumar Gala
2006-06-21 13:04   ` Jon Loeliger
2006-06-21 13:08     ` Kumar Gala
2006-06-21 13:27       ` Jon Loeliger
2006-06-21 21:16   ` Paul Mackerras
2006-05-27 13:17 Paul Mackerras
2006-05-16 12:35 Paul Mackerras
2006-05-09  9:13 Paul Mackerras
2006-05-03 22:29 Paul Mackerras
2006-04-29  6:15 Paul Mackerras
2006-04-29 15:19 ` Olof Johansson
2006-04-29 23:47   ` Paul Mackerras
2006-04-30  3:12     ` Segher Boessenkool
2006-04-30  4:20       ` Olof Johansson
2006-04-30 11:42         ` Arnd Bergmann
2006-04-30 11:57           ` Arnd Bergmann
2006-04-30 15:07             ` Olof Johansson
2006-04-30 13:04           ` Segher Boessenkool
2006-04-30 16:14             ` Arnd Bergmann
2006-04-30 15:03           ` Olof Johansson
2006-04-30 15:07             ` Olof Johansson
2006-04-30  3:50     ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0611211843010.3338@woody.osdl.org \
    --to=torvalds@osdl.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).