* [PATCH] Added QE to the list of default scanned OF devices
@ 2007-02-08 16:56 Andy Fleming
2007-02-08 17:11 ` Kumar Gala
2007-02-08 22:27 ` Benjamin Herrenschmidt
0 siblings, 2 replies; 6+ messages in thread
From: Andy Fleming @ 2007-02-08 16:56 UTC (permalink / raw)
To: Kumar Gala, linuxppc-dev
Signed-off-by: Andrew Fleming <afleming@freescale.com>
---
arch/powerpc/kernel/of_platform.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
index b734517..43c5a00 100644
--- a/arch/powerpc/kernel/of_platform.c
+++ b/arch/powerpc/kernel/of_platform.c
@@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
{ .type = "plb4", },
{ .type = "opb", },
{ .type = "ebc", },
+ { .type = "qe", },
{},
};
--
1.4.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Added QE to the list of default scanned OF devices
2007-02-08 16:56 [PATCH] Added QE to the list of default scanned OF devices Andy Fleming
@ 2007-02-08 17:11 ` Kumar Gala
2007-02-08 22:27 ` Benjamin Herrenschmidt
1 sibling, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2007-02-08 17:11 UTC (permalink / raw)
To: Andy Fleming; +Cc: linuxppc-dev
On Thu, 8 Feb 2007, Andy Fleming wrote:
>
> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> ---
> arch/powerpc/kernel/of_platform.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
applied.
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added QE to the list of default scanned OF devices
2007-02-08 16:56 [PATCH] Added QE to the list of default scanned OF devices Andy Fleming
2007-02-08 17:11 ` Kumar Gala
@ 2007-02-08 22:27 ` Benjamin Herrenschmidt
2007-02-08 22:56 ` Kumar Gala
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2007-02-08 22:27 UTC (permalink / raw)
To: Andy Fleming; +Cc: linuxppc-dev
On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> ---
> arch/powerpc/kernel/of_platform.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
As I said several times on irc, I dislike the "default list" and I'm
tempted to remove it. I'd much prefer if your platform passed in the
list of what it wants exposed.
Ben.
> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/kernel/of_platform.c
> index b734517..43c5a00 100644
> --- a/arch/powerpc/kernel/of_platform.c
> +++ b/arch/powerpc/kernel/of_platform.c
> @@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
> { .type = "plb4", },
> { .type = "opb", },
> { .type = "ebc", },
> + { .type = "qe", },
> {},
> };
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Added QE to the list of default scanned OF devices
2007-02-08 22:27 ` Benjamin Herrenschmidt
@ 2007-02-08 22:56 ` Kumar Gala
2007-02-08 23:25 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2007-02-08 22:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev
On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
>> Signed-off-by: Andrew Fleming <afleming@freescale.com>
>> ---
>> arch/powerpc/kernel/of_platform.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> As I said several times on irc, I dislike the "default list" and I'm
> tempted to remove it. I'd much prefer if your platform passed in the
> list of what it wants exposed.
How about we add 'qe' for now and look at removing the list going
forward.
- k
>> diff --git a/arch/powerpc/kernel/of_platform.c b/arch/powerpc/
>> kernel/of_platform.c
>> index b734517..43c5a00 100644
>> --- a/arch/powerpc/kernel/of_platform.c
>> +++ b/arch/powerpc/kernel/of_platform.c
>> @@ -51,6 +51,7 @@ static struct of_device_id of_default_bu
>> { .type = "plb4", },
>> { .type = "opb", },
>> { .type = "ebc", },
>> + { .type = "qe", },
>> {},
>> };
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Added QE to the list of default scanned OF devices
2007-02-08 22:56 ` Kumar Gala
@ 2007-02-08 23:25 ` Kumar Gala
2007-02-09 1:00 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 6+ messages in thread
From: Kumar Gala @ 2007-02-08 23:25 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Feb 8, 2007, at 4:56 PM, Kumar Gala wrote:
>
> On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
>
>> On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
>>> Signed-off-by: Andrew Fleming <afleming@freescale.com>
>>> ---
>>> arch/powerpc/kernel/of_platform.c | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> As I said several times on irc, I dislike the "default list" and I'm
>> tempted to remove it. I'd much prefer if your platform passed in the
>> list of what it wants exposed.
>
> How about we add 'qe' for now and look at removing the list going
> forward.
Actually, nevermind. I've dropped the patch and will make the guys
do what you are suggesting. Can you look at the other users (cell,
pmac?) and change them so we can remove the "default list"
- k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Added QE to the list of default scanned OF devices
2007-02-08 23:25 ` Kumar Gala
@ 2007-02-09 1:00 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 6+ messages in thread
From: Benjamin Herrenschmidt @ 2007-02-09 1:00 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev
On Thu, 2007-02-08 at 17:25 -0600, Kumar Gala wrote:
> On Feb 8, 2007, at 4:56 PM, Kumar Gala wrote:
>
> >
> > On Feb 8, 2007, at 4:27 PM, Benjamin Herrenschmidt wrote:
> >
> >> On Thu, 2007-02-08 at 10:56 -0600, Andy Fleming wrote:
> >>> Signed-off-by: Andrew Fleming <afleming@freescale.com>
> >>> ---
> >>> arch/powerpc/kernel/of_platform.c | 1 +
> >>> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> As I said several times on irc, I dislike the "default list" and I'm
> >> tempted to remove it. I'd much prefer if your platform passed in the
> >> list of what it wants exposed.
> >
> > How about we add 'qe' for now and look at removing the list going
> > forward.
>
> Actually, nevermind. I've dropped the patch and will make the guys
> do what you are suggesting. Can you look at the other users (cell,
> pmac?) and change them so we can remove the "default list"
Only Cell is using that afaik. I'll do a patch asap.
Ben.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-09 1:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-08 16:56 [PATCH] Added QE to the list of default scanned OF devices Andy Fleming
2007-02-08 17:11 ` Kumar Gala
2007-02-08 22:27 ` Benjamin Herrenschmidt
2007-02-08 22:56 ` Kumar Gala
2007-02-08 23:25 ` Kumar Gala
2007-02-09 1:00 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).