Re: [Linux-fbdev-devel] linux 2.6.21-rc1 : FB Kconfig error

Re: [Linux-fbdev-devel] linux 2.6.21-rc1 : FB Kconfig error

[Geert Uytterhoeven]

On Thu, 22 Feb 2007, Roman Zippel wrote:
> On Wed, 21 Feb 2007, Geert Uytterhoeven wrote:
> > Why doesn't it obey dependencies?
> 
> It was initially created to any override dependencies.
> 
> > > In this case it looks like someone went a little overboard with the select 
> > > usage. It looks like most of the PS3 options could be hidden behind an 
> > > advanced option, then you can also use normal dependencies.
> > 
> > We wanted to have PS3FB and PS3SND (not yet submitted) to select PS3AV, so it
> > gets enabled automatically. Else we need dependencies on things the user
> > shouldn't really need to care about.
> > 
> > What other solution do you propose?
> 
> As I said most PS3 could be hidden behind a PS3_ADVANCED option and use 
> normal dependencies for the rest. Normal users don't care about all 
> the options and advanced users should know what they're doing.

Like this?

Subject: ps3: Introduce CONFIG_PS3_ADVANCED

From: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>

ps3: Introduce CONFIG_PS3_ADVANCED, as suggested by Roman Zippel, and use it to
control questions about PS3 subsystems that may not be obvious for the casual
user.

This gets rid of the following warning:
| drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3' refer to undefined symbol 'PS3_PS3AV'

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Roman Zippel <zippel@linux-m68k.org>
---
 arch/powerpc/platforms/ps3/Kconfig |   29 ++++++++++++++++++++++-------
 drivers/video/Kconfig              |    3 +--
 2 files changed, 23 insertions(+), 9 deletions(-)

--- ps3-linux-2.6.21-rc1.orig/arch/powerpc/platforms/ps3/Kconfig
+++ ps3-linux-2.6.21-rc1/arch/powerpc/platforms/ps3/Kconfig
@@ -1,9 +1,25 @@
 menu "PS3 Platform Options"
 	depends on PPC_PS3
 
+config PS3_ADVANCED
+	depends on PPC_PS3
+	bool "PS3 Advanced configuration options"
+	default n
+	help
+	  This gives you access to some advanced options for the PS3. The
+	  defaults should be fine for most users, but these options may make
+	  it possible to better control the kernel configuration if you know
+	  what you are doing.
+
+	  Note that the answer to this question won't directly affect the
+	  kernel: saying N will just cause the configurator to skip all
+	  the questions about these options.
+
+	  Most users should say N to this question.
+
 config PS3_HTAB_SIZE
 	depends on PPC_PS3
-	int "PS3 Platform pagetable size"
+	int "PS3 Platform pagetable size" if PS3_ADVANCED
 	range 18 20
 	default 20
 	help
@@ -42,7 +58,7 @@ config PS3_USE_LPAR_ADDR
 
 config PS3_VUART
 	depends on PPC_PS3
-	bool "PS3 Virtual UART support"
+	bool "PS3 Virtual UART support" if PS3_ADVANCED
 	default y
 	help
 	  Include support for the PS3 Virtual UART.
@@ -52,9 +68,8 @@ config PS3_VUART
 	  general, all users will say Y.
 
 config PS3_PS3AV
-	tristate "PS3 AV settings driver"
-	depends on PPC_PS3
-	select PS3_VUART
+	tristate "PS3 AV settings driver" if PS3_ADVANCED
+	depends on PS3_VUART
 	default y
 	help
 	  Include support for the PS3 AV Settings driver.
@@ -63,8 +78,8 @@ config PS3_PS3AV
 	  general, all users will say Y or M.
 
 config PS3_SYS_MANAGER
-	bool "PS3 System Manager driver"
-	select PS3_VUART
+	bool "PS3 System Manager driver" if PS3_ADVANCED
+	depends on PS3_VUART
 	default y
 	help
 	  Include support for the PS3 System Manager.
--- ps3-linux-2.6.21-rc1.orig/drivers/video/Kconfig
+++ ps3-linux-2.6.21-rc1/drivers/video/Kconfig
@@ -1618,8 +1618,7 @@ config FB_IBM_GXT4500
 
 config FB_PS3
 	bool "PS3 GPU framebuffer driver"
-	depends on FB && PPC_PS3
-	select PS3_PS3AV
+	depends on FB && PS3_PS3AV
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: [Linux-fbdev-devel] linux 2.6.21-rc1 : FB Kconfig error

[Roman Zippel]

Hi,

On Thu, 22 Feb 2007, Geert Uytterhoeven wrote:

> Like this?
> 
> Subject: ps3: Introduce CONFIG_PS3_ADVANCED

Looks good.

> --- ps3-linux-2.6.21-rc1.orig/arch/powerpc/platforms/ps3/Kconfig
> +++ ps3-linux-2.6.21-rc1/arch/powerpc/platforms/ps3/Kconfig
> @@ -1,9 +1,25 @@
>  menu "PS3 Platform Options"
>  	depends on PPC_PS3
>  
> +config PS3_ADVANCED
> +	depends on PPC_PS3
> +	bool "PS3 Advanced configuration options"
> +	default n

except that this default is not really necessary.

bye, Roman

[PATCH] ps3: Introduce CONFIG_PS3_ADVANCED

[Geert Uytterhoeven]

ps3: Introduce CONFIG_PS3_ADVANCED, as suggested by Roman Zippel, and use it to
control questions about PS3 subsystems that may not be obvious for the casual
user.

This gets rid of the following warning on non-powerpc platforms:
| drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3' refer to undefined symbol 'PS3_PS3AV'

Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
---
 arch/powerpc/platforms/ps3/Kconfig |   28 +++++++++++++++++++++-------
 drivers/video/Kconfig              |    3 +--
 2 files changed, 22 insertions(+), 9 deletions(-)

--- ps3-linux-2.6.21-rc1.orig/arch/powerpc/platforms/ps3/Kconfig
+++ ps3-linux-2.6.21-rc1/arch/powerpc/platforms/ps3/Kconfig
@@ -1,9 +1,24 @@
 menu "PS3 Platform Options"
 	depends on PPC_PS3
 
+config PS3_ADVANCED
+	depends on PPC_PS3
+	bool "PS3 Advanced configuration options"
+	help
+	  This gives you access to some advanced options for the PS3. The
+	  defaults should be fine for most users, but these options may make
+	  it possible to better control the kernel configuration if you know
+	  what you are doing.
+
+	  Note that the answer to this question won't directly affect the
+	  kernel: saying N will just cause the configurator to skip all
+	  the questions about these options.
+
+	  Most users should say N to this question.
+
 config PS3_HTAB_SIZE
 	depends on PPC_PS3
-	int "PS3 Platform pagetable size"
+	int "PS3 Platform pagetable size" if PS3_ADVANCED
 	range 18 20
 	default 20
 	help
@@ -42,7 +57,7 @@ config PS3_USE_LPAR_ADDR
 
 config PS3_VUART
 	depends on PPC_PS3
-	bool "PS3 Virtual UART support"
+	bool "PS3 Virtual UART support" if PS3_ADVANCED
 	default y
 	help
 	  Include support for the PS3 Virtual UART.
@@ -52,9 +67,8 @@ config PS3_VUART
 	  general, all users will say Y.
 
 config PS3_PS3AV
-	tristate "PS3 AV settings driver"
-	depends on PPC_PS3
-	select PS3_VUART
+	tristate "PS3 AV settings driver" if PS3_ADVANCED
+	depends on PS3_VUART
 	default y
 	help
 	  Include support for the PS3 AV Settings driver.
@@ -63,8 +77,8 @@ config PS3_PS3AV
 	  general, all users will say Y or M.
 
 config PS3_SYS_MANAGER
-	bool "PS3 System Manager driver"
-	select PS3_VUART
+	bool "PS3 System Manager driver" if PS3_ADVANCED
+	depends on PS3_VUART
 	default y
 	help
 	  Include support for the PS3 System Manager.
--- ps3-linux-2.6.21-rc1.orig/drivers/video/Kconfig
+++ ps3-linux-2.6.21-rc1/drivers/video/Kconfig
@@ -1618,8 +1618,7 @@ config FB_IBM_GXT4500
 
 config FB_PS3
 	bool "PS3 GPU framebuffer driver"
-	depends on FB && PPC_PS3
-	select PS3_PS3AV
+	depends on FB && PS3_PS3AV
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven@sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium

Re: [PATCH] ps3: Introduce CONFIG_PS3_ADVANCED

[Geoff Levand]

Geert Uytterhoeven wrote:
> ps3: Introduce CONFIG_PS3_ADVANCED, as suggested by Roman Zippel, and use it to
> control questions about PS3 subsystems that may not be obvious for the casual
> user.
> 
> This gets rid of the following warning on non-powerpc platforms:
> | drivers/video/Kconfig:1604:warning: 'select' used by config symbol 'FB_PS3' refer to undefined symbol 'PS3_PS3AV'

Please apply, fixes build warning in 2.6.21-rc1.

Acked-by: Geoff Levand <geoffrey.levand@am.sony.com>