From: Kumar Gala <galak@kernel.crashing.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3] powerpc: change rheap functions to use ulongs instead of pointers
Date: Thu, 12 Apr 2007 18:23:26 -0500 (CDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704121823030.7202@localhost.localdomain> (raw)
In-Reply-To: <1176417846358-git-send-email-timur@freescale.com>
On Thu, 12 Apr 2007, Timur Tabi wrote:
> The rheap allocation functions return a pointer, but the actual value is based
> on how the heap was initialized, and so it can be anything, e.g. an offset
> into a buffer. A ulong is a better representation of the value returned by
> the allocation functions.
>
> This patch changes all of the relevant rheap functions to use a unsigned long
> integers instead of a pointer. In case of an error, the value returned is
> a negative error code that has been cast to an unsigned long. The caller can
> use the IS_ERR_VALUE() macro to check for this.
>
> All code which calls the rheap functions is updated accordingly. Macros
> IS_MURAM_ERR() and IS_DPERR(), have been deleted in favor of IS_ERR_VALUE().
>
> Also added error checking to rh_attach_region().
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
>
> This version of the patch applies to Paul's master. The previous version was
> intended for for-2.6.22, but it also had some errors in it that would prevent
> it from applying to any tree.
>
> arch/powerpc/lib/rheap.c | 117 ++++++++++++++++++-------------
> arch/powerpc/sysdev/commproc.c | 20 +++---
> arch/powerpc/sysdev/cpm2_common.c | 21 +++---
> arch/powerpc/sysdev/qe_lib/qe.c | 29 ++++----
> arch/powerpc/sysdev/qe_lib/ucc_fast.c | 5 +-
> arch/powerpc/sysdev/qe_lib/ucc_slow.c | 7 +-
> arch/ppc/8xx_io/commproc.c | 22 +++---
> arch/ppc/lib/rheap.c | 95 +++++++++++++------------
> arch/ppc/syslib/cpm2_common.c | 23 +++---
> drivers/net/fs_enet/mac-scc.c | 2 +-
> drivers/net/ucc_geth.c | 30 ++++----
> drivers/serial/cpm_uart/cpm_uart_cpm1.c | 4 +-
> drivers/serial/cpm_uart/cpm_uart_cpm2.c | 4 +-
> include/asm-powerpc/qe.h | 13 +---
> include/asm-ppc/commproc.h | 13 +---
> include/asm-ppc/cpm2.h | 13 +---
> include/asm-ppc/rheap.h | 20 +++---
> 17 files changed, 221 insertions(+), 217 deletions(-)
applied.
- k
prev parent reply other threads:[~2007-04-12 23:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 22:44 [PATCH v3] powerpc: change rheap functions to use ulongs instead of pointers Timur Tabi
2007-04-12 23:23 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704121823030.7202@localhost.localdomain \
--to=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).