RE: Porting RapidIO from ppc arch to powerpc arch in support of MPC8641D

[Kumar Gala <galak@kernel.crashing.org>]

On Wed, 23 May 2007, Zhang Wei-r63237 wrote:

> > So I'm taking the boot/dts/mpc8641_hpcn.dts and producing a new
> > mpc8641D_umem.dts with the following addition to the soc.
> >
> > srio@c0000 {
> >                 device_type = "srio";
> >                 compatible = "86xx,85xx";

We really need to think about this, is their really any difference between
srio and prio from a software view point?

> > 		reg = <c0000 20000>;
> > 		law = <400000000 e00000000>;
>
> Please use range = <0 address_start size>

The law should really be removed.

>
> > 		dbells = <0 ffff>;
> > 		mboxs = <0 4>;
>
> The dbells and mboxs can be removed. The default setting in rio is okay.

this could possibly be useful.

>
> >                 interrupt-parent = <&mpic>;
> >                 interrupts = <30 1 31 1 32 1 35 1 36 1 37 1 38 1>;
> >               };
> >
> Do you really use all of this interrupts? In my test, three <32 2 35 2
> 36 2> are okay, and the sense is 2.

I think we need to list all the interrupts possible from RIO, not just the
ones the driver happens to use.

- k