Re: [PATCH] IDE: Remove remnants related to dead BLK_DEV_MAC_MEDIABAY CONFIG variable.

Re: [PATCH] IDE: Remove remnants related to dead BLK_DEV_MAC_MEDIABAY CONFIG variable.

[Brad Boyer]

On Sun, Jun 03, 2007 at 01:52:02PM -0400, Robert P. J. Day wrote:
> Remove the two snippets of code conditional on the non-existent CONFIG
> variable CONFIG_BLK_DEV_MAC_MEDIABAY.

This is the wrong list. The macide driver is for m68k Macintoshes, so
you really need to send this to the linux-m68k list. It looks like this
was originally a copy of the IDE driver for ppc based Macintoshes and
this particular feature was never finished.

Just in case you don't know where to find the linux-m68k mailing list,
it is hosted on vger.kernel.org.

	Brad Boyer
	flar@allandria.com

[PATCH] IDE: Remove remnants related to dead BLK_DEV_MAC_MEDIABAY CONFIG variable.

[Robert P. J. Day]

Remove the two snippets of code conditional on the non-existent CONFIG
variable CONFIG_BLK_DEV_MAC_MEDIABAY.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

diff --git a/drivers/ide/legacy/macide.c b/drivers/ide/legacy/macide.c
index c211fc7..b557c45 100644
--- a/drivers/ide/legacy/macide.c
+++ b/drivers/ide/legacy/macide.c
@@ -77,15 +77,6 @@ int macide_ack_intr(ide_hwif_t* hwif)
 	return 0;
 }

-#ifdef CONFIG_BLK_DEV_MAC_MEDIABAY
-static void macide_mediabay_interrupt(int irq, void *dev_id)
-{
-	int state = baboon->mb_status & 0x04;
-
-	printk(KERN_INFO "macide: media bay %s detected\n", state? "removal":"insertion");
-}
-#endif
-
 /*
  * Probe for a Macintosh IDE interface
  */
@@ -128,11 +119,6 @@ void macide_init(void)
 			ide_drive_t *drive = &ide_hwifs[index].drives[0];
 			drive->capacity64 = drive->cyl*drive->head*drive->sect;

-#ifdef CONFIG_BLK_DEV_MAC_MEDIABAY
-			request_irq(IRQ_BABOON_2, macide_mediabay_interrupt,
-					IRQ_FLG_FAST, "mediabay",
-					macide_mediabay_interrupt);
-#endif
 		}
 		break;

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] IDE: Remove remnants related to dead BLK_DEV_MAC_MEDIABAY CONFIG variable.

[Robert P. J. Day]

On Sun, 3 Jun 2007, Brad Boyer wrote:

> On Sun, Jun 03, 2007 at 01:52:02PM -0400, Robert P. J. Day wrote:
> > Remove the two snippets of code conditional on the non-existent CONFIG
> > variable CONFIG_BLK_DEV_MAC_MEDIABAY.
>
> This is the wrong list. The macide driver is for m68k Macintoshes,
> so you really need to send this to the linux-m68k list. It looks
> like this was originally a copy of the IDE driver for ppc based
> Macintoshes and this particular feature was never finished.
>
> Just in case you don't know where to find the linux-m68k mailing
> list, it is hosted on vger.kernel.org.

ok, i'll do that, thanks.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] IDE: Remove remnants related to dead BLK_DEV_MAC_MEDIABAY CONFIG variable.

[Brad Boyer]

On Sun, Jun 03, 2007 at 09:07:52PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Ehm, I'm guilty for this mistake since I've advised Robert
> to cc: wrong list (thinko caused by mediabay == ppc assumption).
> 
> Sorry for this. :)

Don't worry about it. I would have missed it if I wasn't active in
the m68k Mac support. I'm pretty sure the PowerBook 190 was the only
m68k Mac with a media bay, and it's really just a PB 5300 with the
ppc chip swapped out for a 68LC040 to make a cheaper model. They're
fundamentally the same system in most ways. Hopefully we can merge
more of the m68k Mac support code with the ppc Mac support at some
point in the future, but that's still a fair amount of work.

	Brad Boyer
	flar@allandria.com

Re: [PATCH] IDE: Remove remnants related to dead BLK_DEV_MAC_MEDIABAY CONFIG variable.

[Bartlomiej Zolnierkiewicz]

Hi,

Ehm, I'm guilty for this mistake since I've advised Robert
to cc: wrong list (thinko caused by mediabay == ppc assumption).

Sorry for this. :)

Robert: I'll apply both patches in a few days if there are no
complains from m68k/scsi people.

Thanks,
Bart

On Sunday 03 June 2007, Brad Boyer wrote:
> On Sun, Jun 03, 2007 at 01:52:02PM -0400, Robert P. J. Day wrote:
> > Remove the two snippets of code conditional on the non-existent CONFIG
> > variable CONFIG_BLK_DEV_MAC_MEDIABAY.
> 
> This is the wrong list. The macide driver is for m68k Macintoshes, so
> you really need to send this to the linux-m68k list. It looks like this
> was originally a copy of the IDE driver for ppc based Macintoshes and
> this particular feature was never finished.
> 
> Just in case you don't know where to find the linux-m68k mailing list,
> it is hosted on vger.kernel.org.
> 
> 	Brad Boyer
> 	flar@allandria.com