From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 3E915DDECE for ; Wed, 18 Jul 2007 15:03:08 +1000 (EST) Date: Wed, 18 Jul 2007 00:02:46 -0500 (CDT) From: Kumar Gala To: bzolnier@gmail.com Subject: compile error if CONFIG_BLOCK not enabled related to linux/ide.h include Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , M: bzolnier@gmail.com L: linux-ide@vger.kernel.org We get the following compile error if CONFIG_BLOCK isn't enabled: CC arch/powerpc/kernel/setup_32.o In file included from arch/powerpc/kernel/setup_32.c:14: include/linux/ide.h:558: error: expected specifier-qualifier-list before 'request_queue_t' include/linux/ide.h:696: warning: 'struct request' declared inside parameter list include/linux/ide.h:696: warning: its scope is only this definition or declaration, which is probably not what you want include/linux/ide.h:820: warning: 'struct request' declared inside parameter list include/linux/ide.h:853: error: field 'wrq' has incomplete type include/linux/ide.h:1205: error: expected ')' before '*' token make[1]: *** [arch/powerpc/kernel/setup_32.o] Error 1 make: *** [arch/powerpc/kernel] Error 2 What I'm trying to figure out is if include/linux/ide.h should be wrapped in a #if defined(CONFIG_IDE) || defined(CONFIG_IDE_MODULE) or if there is some other desired way to handle this. This seems to stem from the fact that include/linux/blkdev.h is wrapped in a CONFIG_BLOCK and thus request_queue_t isn't always defined. - k