Re: [PATCH] PPC: Prevent direct inclusion of <asm/rwsem.h>.

["Robert P. J. Day" <rpjday@mindspring.com>]

On Wed, 18 Jul 2007, Kumar Gala wrote:

>
> On Jul 18, 2007, at 8:36 AM, Robert P. J. Day wrote:
>
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>
> Can you provide some commit description as to why we are doing this?
>
> - k
>
> >
> > ---
> >
> >   not compile-tested, so if there's a flaw here somewhere, feel free
> > to tweak it.
> >
> >  arch/ppc/syslib/ocp.c       |    2 +-
> >  include/asm-powerpc/rwsem.h |    4 ++++
> >  include/asm-ppc/ocp.h       |    2 +-
> >  3 files changed, 6 insertions(+), 2 deletions(-)

based on the pattern across all architectures, it would seem that
asm/rwsem.h is not *meant* to be included directly, but only via
linux/rwsem.h.  i'm not sure if that's the kind of rationale you're
looking for, or if you want a more technical description.

at the moment, ppc is the only architecture that is doing the above,
but it may be that there's a good reason for that that i'm just not
aware of.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================