From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rubicon.netdirect.ca (nic.NetDirect.CA [216.16.235.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 7397CDDED2 for ; Thu, 19 Jul 2007 00:22:52 +1000 (EST) Date: Wed, 18 Jul 2007 10:20:50 -0400 (EDT) From: "Robert P. J. Day" To: Kumar Gala Subject: Re: [PATCH] PPC: Prevent direct inclusion of . In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Linux PPC Mailing List , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 18 Jul 2007, Kumar Gala wrote: > > On Jul 18, 2007, at 8:36 AM, Robert P. J. Day wrote: > > > > > Signed-off-by: Robert P. J. Day > > Can you provide some commit description as to why we are doing this? > > - k > > > > > --- > > > > not compile-tested, so if there's a flaw here somewhere, feel free > > to tweak it. > > > > arch/ppc/syslib/ocp.c | 2 +- > > include/asm-powerpc/rwsem.h | 4 ++++ > > include/asm-ppc/ocp.h | 2 +- > > 3 files changed, 6 insertions(+), 2 deletions(-) based on the pattern across all architectures, it would seem that asm/rwsem.h is not *meant* to be included directly, but only via linux/rwsem.h. i'm not sure if that's the kind of rationale you're looking for, or if you want a more technical description. at the moment, ppc is the only architecture that is doing the above, but it may be that there's a good reason for that that i'm just not aware of. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ========================================================================