linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Esben Nielsen <nielsen.esben@googlemail.com>
To: Robert Woodworth <rwoodworth@securics.com>
Cc: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>,
	linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH 3/3] Add support for xupv2p and ml410 boards.
Date: Wed, 22 Aug 2007 12:20:46 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0708221214210.4037@frodo.shire> (raw)
In-Reply-To: <1187751864.6266.6.camel@PisteOff>



On Tue, 21 Aug 2007, Robert Woodworth wrote:

> Should the xparameters????.h file *really* be included in the tree?
>
> This file is completely board/EDK/ISE/synthesis specific.  I'd rather it
> not be included and have people copy theirs from EDK.
> Or as I have done, sym-link it from my EDK project.
>
>
> Woody.
>

The solution below is in line with what we do in our 2.4 kernel to support
several of our own boards.
When you distribute the kernel you have to distribute the source as well. 
You thus have to include xparameters.h such the kernel can be rebuild by 
the receiver.

Esben

>
>
> On Tue, 2007-08-21 at 17:53 -0700, wolfgang.reissnegger@xilinx.com
> wrote:
>> From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
>
>> diff --git a/arch/ppc/platforms/4xx/xparameters/xparameters.h b/arch/ppc/platforms/4xx/xparameters/xparameters.h
>> index 01aa043..34d9844 100644
>> --- a/arch/ppc/platforms/4xx/xparameters/xparameters.h
>> +++ b/arch/ppc/platforms/4xx/xparameters/xparameters.h
>> @@ -15,8 +15,12 @@
>>
>>  #if defined(CONFIG_XILINX_ML300)
>>    #include "xparameters_ml300.h"
>> +#elif defined(CONFIG_XILINX_XUPV2P)
>> +  #include "xparameters_xupv2p.h"
>>  #elif defined(CONFIG_XILINX_ML403)
>>    #include "xparameters_ml403.h"
>> +#elif defined(CONFIG_XILINX_ML41x)
>> +  #include "xparameters_ml41x.h"
>>  #else
>>    /* Add other board xparameter includes here before the #else */
>>    #error No xparameters_*.h file included
>> diff --git a/arch/ppc/platforms/4xx/xparameters/xparameters_ml41x.h b/arch/ppc/platforms/4xx/xparameters/xparameters_ml41x.h
>> new file mode 100644
>> index 0000000..06dac67
>> --- /dev/null
>> +++ b/arch/ppc/platforms/4xx/xparameters/xparameters_ml41x.h
>> @@ -0,0 +1,277 @@
>> +
>> +/*******************************************************************
>> +*
>> +* CAUTION: This file is automatically generated by libgen.
>> +* Version: Xilinx EDK 8.2.02 EDK_Im_Sp2.4
>> +* DO NOT EDIT.
>> +*
>> +* Copyright (c) 2005 Xilinx, Inc.  All rights reserved.
>> +*
>> +* Description: Driver parameters
>> +*
>> +*******************************************************************/
>> +
>
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
>

  parent reply	other threads:[~2007-08-22 10:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1187743993171-git-send-email-wolfgang.reissnegger@xilinx.com>
2007-08-22  0:53 ` [PATCH 2/3] Consolidate XILINX_VIRTEX board support wolfgang.reissnegger
2007-08-23 20:34   ` Robert Woodworth
     [not found] ` <1187743993360-git-send-email-wolfgang.reissnegger@xilinx.com>
2007-08-22  0:53   ` [PATCH 3/3] Add support for xupv2p and ml410 boards wolfgang.reissnegger
2007-08-22  1:13     ` Josh Boyer
2007-08-22  3:04     ` Robert Woodworth
2007-08-22  3:25       ` Grant Likely
2007-08-22 10:20       ` Esben Nielsen [this message]
     [not found] <11877426871932-git-send-email-w.reissnegger@gmx.net>
     [not found] ` <1187742687475-git-send-email-w.reissnegger@gmx.net>
2007-08-22  0:31   ` Wolfgang Reissnegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0708221214210.4037@frodo.shire \
    --to=nielsen.esben@googlemail.com \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=rwoodworth@securics.com \
    --cc=stephen.neuendorffer@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).