* [PATCH] ucc_geth: kill unused include
@ 2007-08-23 2:51 Kumar Gala
2007-08-23 2:54 ` David Gibson
2007-08-25 4:37 ` Jeff Garzik
0 siblings, 2 replies; 4+ messages in thread
From: Kumar Gala @ 2007-08-23 2:51 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, Li Yang, Paul Mackerras, linuxppc-dev
The ucc_geth_mii code is based on the gianfar_mii code that use to include
ocp.h. ucc never need this and it causes issues when we want to kill
arch/ppc includes from arch/powerpc.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
Jeff, if you issue with this for 2.6.23, I'd prefer to push this via
the powerpc.git trees in 2.6.24 as part of a larger cleanup. Let me know
one way or the other.
- k
drivers/net/ucc_geth_mii.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c
index 6c257b8..df884f0 100644
--- a/drivers/net/ucc_geth_mii.c
+++ b/drivers/net/ucc_geth_mii.c
@@ -32,7 +32,6 @@
#include <linux/mm.h>
#include <linux/module.h>
#include <linux/platform_device.h>
-#include <asm/ocp.h>
#include <linux/crc32.h>
#include <linux/mii.h>
#include <linux/phy.h>
--
1.5.2.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ucc_geth: kill unused include
2007-08-23 2:51 [PATCH] ucc_geth: kill unused include Kumar Gala
@ 2007-08-23 2:54 ` David Gibson
2007-08-25 4:37 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: David Gibson @ 2007-08-23 2:54 UTC (permalink / raw)
To: Kumar Gala; +Cc: netdev, Li Yang, Paul Mackerras, Jeff Garzik, linuxppc-dev
On Wed, Aug 22, 2007 at 09:51:03PM -0500, Kumar Gala wrote:
> The ucc_geth_mii code is based on the gianfar_mii code that use to include
> ocp.h. ucc never need this and it causes issues when we want to kill
> arch/ppc includes from arch/powerpc.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ucc_geth: kill unused include
2007-08-23 2:51 [PATCH] ucc_geth: kill unused include Kumar Gala
2007-08-23 2:54 ` David Gibson
@ 2007-08-25 4:37 ` Jeff Garzik
2007-08-25 14:57 ` Kumar Gala
1 sibling, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-08-25 4:37 UTC (permalink / raw)
To: Kumar Gala; +Cc: netdev, Li Yang, Paul Mackerras, linuxppc-dev
Kumar Gala wrote:
> The ucc_geth_mii code is based on the gianfar_mii code that use to include
> ocp.h. ucc never need this and it causes issues when we want to kill
> arch/ppc includes from arch/powerpc.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>
> Jeff, if you issue with this for 2.6.23, I'd prefer to push this via
> the powerpc.git trees in 2.6.24 as part of a larger cleanup. Let me know
> one way or the other.
>
> - k
>
> drivers/net/ucc_geth_mii.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c
> index 6c257b8..df884f0 100644
> --- a/drivers/net/ucc_geth_mii.c
> +++ b/drivers/net/ucc_geth_mii.c
> @@ -32,7 +32,6 @@
> #include <linux/mm.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
> -#include <asm/ocp.h>
> #include <linux/crc32.h>
> #include <linux/mii.h>
Feel free to push via PPC git
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ucc_geth: kill unused include
2007-08-25 4:37 ` Jeff Garzik
@ 2007-08-25 14:57 ` Kumar Gala
0 siblings, 0 replies; 4+ messages in thread
From: Kumar Gala @ 2007-08-25 14:57 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, Li Yang, Paul Mackerras, linuxppc-dev
On Aug 24, 2007, at 11:37 PM, Jeff Garzik wrote:
> Kumar Gala wrote:
>> The ucc_geth_mii code is based on the gianfar_mii code that use to
>> include
>> ocp.h. ucc never need this and it causes issues when we want to kill
>> arch/ppc includes from arch/powerpc.
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> Jeff, if you issue with this for 2.6.23, I'd prefer to push this via
>> the powerpc.git trees in 2.6.24 as part of a larger cleanup. Let
>> me know
>> one way or the other.
>> - k
>> drivers/net/ucc_geth_mii.c | 1 -
>> 1 files changed, 0 insertions(+), 1 deletions(-)
>> diff --git a/drivers/net/ucc_geth_mii.c b/drivers/net/ucc_geth_mii.c
>> index 6c257b8..df884f0 100644
>> --- a/drivers/net/ucc_geth_mii.c
>> +++ b/drivers/net/ucc_geth_mii.c
>> @@ -32,7 +32,6 @@
>> #include <linux/mm.h>
>> #include <linux/module.h>
>> #include <linux/platform_device.h>
>> -#include <asm/ocp.h>
>> #include <linux/crc32.h>
>> #include <linux/mii.h>
>
> Feel free to push via PPC git
will do.
thanks
- k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-25 14:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-23 2:51 [PATCH] ucc_geth: kill unused include Kumar Gala
2007-08-23 2:54 ` David Gibson
2007-08-25 4:37 ` Jeff Garzik
2007-08-25 14:57 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).