[FDT][PATCH] Print out the total size as part of ftdump

[FDT][PATCH] Print out the total size as part of ftdump

[Kumar Gala]

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 ftdump.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ftdump.c b/ftdump.c
index 577c2cf..53343d7 100644
--- a/ftdump.c
+++ b/ftdump.c
@@ -87,6 +87,7 @@ static void dump_blob(void *blob)
 	char *p_struct = blob + be32_to_cpu(bph->off_dt_struct);
 	char *p_strings = blob + be32_to_cpu(bph->off_dt_strings);
 	uint32_t version = be32_to_cpu(bph->version);
+	uint32_t totalsize = be32_to_cpu(bph->totalsize);
 	uint32_t tag;
 	char *p;
 	char *s, *t;
@@ -98,6 +99,7 @@ static void dump_blob(void *blob)
 	shift = 4;

 	printf("// Version 0x%x tree\n", version);
+	printf("// Totalsize 0x%x(%d)\n", totalsize, totalsize);
 	for (i = 0; ; i++) {
 		addr = be64_to_cpu(p_rsvmap[i].address);
 		size = be64_to_cpu(p_rsvmap[i].size);
-- 
1.5.3.4

Re: [FDT][PATCH] Print out the total size as part of ftdump

[David Gibson]

On Tue, Dec 04, 2007 at 10:33:20AM -0600, Kumar Gala wrote:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

You know, the whole batch of fprintf()s of header information in
dt_from_blob() are really just a debugging hack that uglifies dtc's
output.  The whole lot could be moved over to ftdump instead, which
is, after all, *supposed* to be a debugging hack.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [FDT][PATCH] Print out the total size as part of ftdump

[Kumar Gala]

On Dec 4, 2007, at 4:20 PM, David Gibson wrote:

> On Tue, Dec 04, 2007 at 10:33:20AM -0600, Kumar Gala wrote:
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>
> You know, the whole batch of fprintf()s of header information in
> dt_from_blob() are really just a debugging hack that uglifies dtc's
> output.  The whole lot could be moved over to ftdump instead, which
> is, after all, *supposed* to be a debugging hack.

Yeah, I realized having a way to dump just the header info was nice.

- k

Re: [FDT][PATCH] Print out the total size as part of ftdump

[Jon Loeliger]

So, like, the other day Kumar Gala mumbled:
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  ftdump.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Applied.

jdl