From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BA0ACDDF50 for ; Sat, 17 May 2008 05:17:47 +1000 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id m4GJHfb3007836 for ; Fri, 16 May 2008 14:17:41 -0500 Date: Fri, 16 May 2008 14:17:41 -0500 (CDT) From: Kumar Gala To: linuxppc-dev@ozlabs.org Subject: [PATCH] [POWERPC] Add a comment about the Book-e tophys/tovirt macros Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , The Book-E versions of tophys/tovirt are not simple no ops to ensure compatibility with their "classic" ppc brethren. --- Added as Hollis and Josh's request. This is in my powerpc-next tree. - k include/asm-powerpc/ppc_asm.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/asm-powerpc/ppc_asm.h b/include/asm-powerpc/ppc_asm.h index 2dbd4e7..70fc433 100644 --- a/include/asm-powerpc/ppc_asm.h +++ b/include/asm-powerpc/ppc_asm.h @@ -356,6 +356,11 @@ END_FTR_SECTION_IFCLR(CPU_FTR_601) #define toreal(rd) #define fromreal(rd) +/* + * We use addis to sure compatible with the "classic" ppc versions + * of these macros that might have rs as 0, which means a value of 0 + * not r0 + */ #define tophys(rd,rs) \ addis rd,rs,0 -- 1.5.4.5