* [PATCH] edac: mpc85xx - Fix building as a module
@ 2008-05-22 4:26 Kumar Gala
2008-05-22 16:13 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Kumar Gala @ 2008-05-22 4:26 UTC (permalink / raw)
To: dougthompson; +Cc: Andrew Morton, linuxppc-dev, bluesmoke-devel, linux-kernel
including of <asm/mpc85xx.h> causes build problems since it doesn't exist.
Also removed warning:
drivers/edac/mpc85xx_edac.c:45: warning: 'mpc85xx_ctl_name' defined but not used
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
This is a fix for 2.6.26.
- k
drivers/edac/mpc85xx_edac.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 065732d..d49361b 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -20,7 +20,6 @@
#include <linux/of_platform.h>
#include <linux/of_device.h>
-#include <asm/mpc85xx.h>
#include "edac_module.h"
#include "edac_core.h"
#include "mpc85xx_edac.h"
@@ -43,8 +42,6 @@ static u32 orig_pci_err_en;
static u32 orig_l2_err_disable;
static u32 orig_hid1;
-static const char *mpc85xx_ctl_name = "MPC85xx";
-
/************************ MC SYSFS parts ***********************************/
static ssize_t mpc85xx_mc_inject_data_hi_show(struct mem_ctl_info *mci,
--
1.5.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] edac: mpc85xx - Fix building as a module
2008-05-22 4:26 [PATCH] edac: mpc85xx - Fix building as a module Kumar Gala
@ 2008-05-22 16:13 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2008-05-22 16:13 UTC (permalink / raw)
To: Kumar Gala
Cc: Andrew Morton, linuxppc-dev, bluesmoke-devel, linux-kernel,
dougthompson
Acked-by: Dave Jiang <djiang@mvista.com>
Kumar Gala wrote:
> including of <asm/mpc85xx.h> causes build problems since it doesn't exist.
>
> Also removed warning:
> drivers/edac/mpc85xx_edac.c:45: warning: 'mpc85xx_ctl_name' defined but not used
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>
> This is a fix for 2.6.26.
>
> - k
>
> drivers/edac/mpc85xx_edac.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index 065732d..d49361b 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -20,7 +20,6 @@
>
> #include <linux/of_platform.h>
> #include <linux/of_device.h>
> -#include <asm/mpc85xx.h>
> #include "edac_module.h"
> #include "edac_core.h"
> #include "mpc85xx_edac.h"
> @@ -43,8 +42,6 @@ static u32 orig_pci_err_en;
> static u32 orig_l2_err_disable;
> static u32 orig_hid1;
>
> -static const char *mpc85xx_ctl_name = "MPC85xx";
> -
> /************************ MC SYSFS parts ***********************************/
>
> static ssize_t mpc85xx_mc_inject_data_hi_show(struct mem_ctl_info *mci,
--
------------------------------------------------------
Dave Jiang
Software Engineer
MontaVista Software, Inc.
http://www.mvista.com
------------------------------------------------------
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-05-22 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-22 4:26 [PATCH] edac: mpc85xx - Fix building as a module Kumar Gala
2008-05-22 16:13 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).