linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc/ep8248e: Unconditionally select PHYLIB for mdio_bitbang
@ 2008-07-16 23:05 Kumar Gala
  0 siblings, 0 replies; only message in thread
From: Kumar Gala @ 2008-07-16 23:05 UTC (permalink / raw)
  To: linuxppc-dev; +Cc: davej, akpm, torvalds, linux-kernel

Its possible to build the phylib as a module, however this breaks the
board code because alloc_mdio_bitbang and mdiobus_register are not
available if we build as a module.  These are needed by the board code
since it implements the low level mdio bitbang ops.

So we unconditionally select PHYLIB to ensure its built into the kernel
if we are building in EP8248E support.

Long term we should look at moving the mdio_ops into its own file so it
can be built as a module.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---

This patch supercededs:

[PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET

I've reverted the old patch and applied the new patch in my git tree and
have asked Ben to pull and push it to Linus.

- k

 arch/powerpc/platforms/82xx/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/platforms/82xx/Kconfig b/arch/powerpc/platforms/82xx/Kconfig
index 1c8034b..75eb1ed 100644
--- a/arch/powerpc/platforms/82xx/Kconfig
+++ b/arch/powerpc/platforms/82xx/Kconfig
@@ -30,6 +30,7 @@ config EP8248E
 	select 8272
 	select 8260
 	select FSL_SOC
+	select PHYLIB
 	select MDIO_BITBANG
 	help
 	  This enables support for the Embedded Planet EP8248E board.
-- 
1.5.5.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-07-16 23:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-16 23:05 [PATCH] powerpc/ep8248e: Unconditionally select PHYLIB for mdio_bitbang Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).