From: Kumar Gala <galak@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] irq: Maintain user set affinity
Date: Tue, 4 Nov 2008 10:31:05 -0600 (CST) [thread overview]
Message-ID: <Pine.LNX.4.64.0811041030520.25054@blarg.am.freescale.net> (raw)
>From 819ad3ed4660f4238e053728a8b5aa93d22b13d7 Mon Sep 17 00:00:00 2001
From: Kumar Gala <galak@kernel.crashing.org>
Date: Tue, 4 Nov 2008 10:13:53 -0600
Subject: [PATCH 1/1] irq: Maintain user set affinity
This addresses a regression in that if a user specified an affinity
for an interrupt that affinity information would get reset between
a request_irq(), free_irq() and request_irq() for the same irq.
On example of this is bringing up an ethernet interface, taking
it down and bringing it back up again.
Instead of always using the irq_default_affinity we use the
previous setting of the IRQs affinity with the assumption that
at boot the IRQs affinity will be set to irq_default_affinity.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
kernel/irq/manage.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index c498a1b..ea7d11b 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -115,9 +115,12 @@ int irq_select_affinity(unsigned int irq)
if (!irq_can_set_affinity(irq))
return 0;
- cpus_and(mask, cpu_online_map, irq_default_affinity);
-
desc = irq_to_desc(irq);
+
+ mask = desc->affinity;
+
+ cpus_and(mask, cpu_online_map, mask);
+
desc->affinity = mask;
desc->chip->set_affinity(irq, mask);
--
1.5.5.1
next reply other threads:[~2008-11-04 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 16:31 Kumar Gala [this message]
2008-11-06 21:35 ` [PATCH 1/1] irq: Maintain user set affinity Andrew Morton
2008-11-06 23:23 ` Kumar Gala
2008-11-08 22:13 ` Yinghai Lu
2008-11-08 22:12 ` Yinghai Lu
2008-11-08 22:17 ` Benjamin Herrenschmidt
2008-11-09 0:01 ` Yinghai Lu
2008-11-09 2:17 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811041030520.25054@blarg.am.freescale.net \
--to=galak@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tglx@linutronix.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).