LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Trent Piepho <tpiepho@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Silence timebase sync code
Date: Mon, 17 Nov 2008 14:22:08 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0811171421090.11673@t2.domain.actdsltmp> (raw)
In-Reply-To: <49889E01-9433-41BE-A6F1-66127856D482@kernel.crashing.org>

On Mon, 17 Nov 2008, Kumar Gala wrote:
> On Nov 17, 2008, at 3:58 PM, Trent Piepho wrote:
>
>> It's over a dozen lines of output and doesn't appear to provide any useful
>> information.  Even after looking at the code, I'm in the dark about what
>> "score 299, offset 250" means.
>> 
>> Signed-off-by: Trent Piepho <tpiepho@freescale.com>
>> ---
>> arch/powerpc/kernel/smp-tbsync.c |   12 ++++--------
>> 1 files changed, 4 insertions(+), 8 deletions(-)
>> 
>> diff --git a/arch/powerpc/kernel/smp-tbsync.c 
>> b/arch/powerpc/kernel/smp-tbsync.c
>> index bc892e6..b590135 100644
>> --- a/arch/powerpc/kernel/smp-tbsync.c
>> +++ b/arch/powerpc/kernel/smp-tbsync.c
>> @@ -113,7 +113,7 @@ void __devinit smp_generic_give_timebase(void)
>> {
>>  int i, score, score2, old, min=0, max=5000, offset=1000;
>> 
>> -	printk("Synchronizing timebase\n");
>> +	pr_info("Synchronizing timebase\n");
>
> I think its useful to leave this as a printk.

#define pr_info(fmt, arg...) \
         printk(KERN_INFO fmt, ##arg)

Isn't printk with no level tag the same as KERN_INFO?

  reply	other threads:[~2008-11-17 22:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-17 21:58 [PATCH] powerpc: Silence timebase sync code Trent Piepho
2008-11-17 22:14 ` Kumar Gala
2008-11-17 22:22   ` Trent Piepho [this message]
2008-11-17 23:28     ` Michael Ellerman
2008-11-18 10:11       ` Trent Piepho
2008-11-18 13:18     ` Kumar Gala
2008-11-18 10:27 ` Benjamin Herrenschmidt
2008-11-19  3:22 ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0811171421090.11673@t2.domain.actdsltmp \
    --to=tpiepho@freescale.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox