From: Trent Piepho <tpiepho@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Fleming Andy <afleming@freescale.com>
Subject: Re: [PATCH] powerpc/85xx: Add support for SMP initialization
Date: Mon, 8 Dec 2008 19:14:26 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0812081855330.4837@t2.domain.actdsltmp> (raw)
In-Reply-To: <1228204546-1506-1-git-send-email-galak@kernel.crashing.org>
On Tue, 2 Dec 2008, Kumar Gala wrote:
> Added 85xx specifc smp_ops structure. We use ePAPR style boot release
> and the MPIC for IPIs at this point.
>
> Additionally added routines for secondary cpu entry and initializtion.
>
> @@ -740,6 +750,9 @@ finish_tlb_load:
> #else
> rlwimi r12, r11, 26, 27, 31 /* extract WIMGE from pte */
> #endif
> +#ifdef CONFIG_SMP
> + ori r12, r12, MAS2_M
> +#endif
> mtspr SPRN_MAS2, r12
Wouldn't it be more efficient to set _PAGE_COHERENT when the pte is created
vs setting MAS2_M each time it's loaded?
Is it correct to set MAS2_M for all pages, even uncached ones?
The code for ioremap() has this:
/* Non-cacheable page cannot be coherent */
if (flags & _PAGE_NO_CACHE)
flags &= ~_PAGE_COHERENT;
It seems odd that ioremap would explictly unset _PAGE_COHERENT when the
code that sets the tlb will just force it back on.
next prev parent reply other threads:[~2008-12-09 3:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 7:55 [PATCH] powerpc/85xx: Add support for SMP initialization Kumar Gala
2008-12-09 3:14 ` Trent Piepho [this message]
2008-12-09 6:40 ` Benjamin Herrenschmidt
2008-12-09 6:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812081855330.4837@t2.domain.actdsltmp \
--to=tpiepho@freescale.com \
--cc=afleming@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox