From: Trent Piepho <tpiepho@freescale.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: linuxppc-dev@ozlabs.org, Pavel Machek <pavel@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] leds: Let GPIO LEDs keep their current state
Date: Tue, 9 Dec 2008 20:33:47 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0812092013030.28806@t2.domain.actdsltmp> (raw)
In-Reply-To: <1228298664.9126.3.camel@ted>
On Wed, 3 Dec 2008, Richard Purdie wrote:
> On Sun, 2008-11-23 at 13:31 +0100, Pavel Machek wrote:
>> On Thu 2008-11-20 17:05:56, Trent Piepho wrote:
>>> I thought of that, but it ends up being more complex. Instead of just
>>> using:
>>> static const struct gpio_led myled = {
>>> .name = "something",
>>> .keep_state = 1,
>>> }
>>>
>>> You'd do something like this:
>>> .default_state = LEDS_GPIO_DEFSTATE_KEEP,
>>>
>>> Is that better?
>>
>> Yes.
>
> Yes, agreed, much better.
Oh very well, I'll change it. But I reserve the right to make a sarcastic
commit message.
prev parent reply other threads:[~2008-12-10 4:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 23:04 OpenFirmware GPIO LED driver Trent Piepho
2008-10-24 23:08 ` [PATCH 1/4] of_gpio: Return GPIO flags from of_get_gpio() Trent Piepho
2008-10-24 23:32 ` Grant Likely
2008-10-28 14:39 ` Anton Vorontsov
2008-10-28 14:53 ` Grant Likely
2008-10-28 15:16 ` Anton Vorontsov
2008-10-28 15:42 ` Grant Likely
2008-10-28 16:56 ` Anton Vorontsov
2008-10-28 17:40 ` Grant Likely
2008-10-30 2:21 ` [PATCH 1/4] of_gpio: Return GPIO flags from of_get_gpio()A Trent Piepho
2008-10-30 11:15 ` Anton Vorontsov
2008-10-31 2:03 ` [PATCH v2] of_gpio: Return GPIO flags from of_get_gpio() Trent Piepho
2008-11-26 16:20 ` Anton Vorontsov
2008-11-26 21:38 ` Paul Mackerras
2008-11-26 22:31 ` Anton Vorontsov
2008-11-26 22:35 ` Trent Piepho
2008-11-26 22:58 ` Anton Vorontsov
2008-11-26 23:32 ` Paul Mackerras
2008-10-24 23:08 ` [PATCH 2/4] leds: Support OpenFirmware led bindings Trent Piepho
2008-10-24 23:50 ` Grant Likely
2008-10-24 23:09 ` [PATCH 3/4] leds: Add option to have GPIO LEDs start on Trent Piepho
2008-10-24 23:59 ` Grant Likely
2008-10-24 23:09 ` [PATCH 4/4] leds: Let GPIO LEDs keep their current state Trent Piepho
2008-10-25 0:04 ` Grant Likely
2008-11-17 14:50 ` Richard Purdie
2008-11-21 1:05 ` Trent Piepho
2008-11-23 12:31 ` Pavel Machek
2008-12-03 10:04 ` Richard Purdie
2008-12-10 4:33 ` Trent Piepho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812092013030.28806@t2.domain.actdsltmp \
--to=tpiepho@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=pavel@suse.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox