From: Trent Piepho <tpiepho@freescale.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org,
MTD mailing list <linux-mtd@lists.infradead.org>,
xyzzy@speakeasy.org
Subject: Re: [PATCH] POWERPC: MTD: Add cached map support to physmap_of MTD driver
Date: Mon, 15 Dec 2008 17:11:58 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0812151653050.28806@t2.domain.actdsltmp> (raw)
In-Reply-To: <18758.62580.416920.482077@cargo.ozlabs.ibm.com>
On Tue, 16 Dec 2008, Paul Mackerras wrote:
> Trent Piepho writes:
>> The MTD system supports operation where a direct mapped flash chip is
>> mapped twice. The normal mapping is a standard ioremap(), which is
>> non-cached and guarded on powerpc. The second mapping is used only for
>> reads and can be cached and non-guarded. Currently, only the pxa2xx
>> mapping driver makes use of this feature. This patch adds support to the
>> physmap_of driver on PPC32 platforms for this cached mapping mode.
>
> Note that having two mappings of the same physical address that differ
> in cacheability is a programming error according to the PowerPC
> architecture.
>
> Do you know that the processor implementations where you want to do
> this can cope with having two mappings with different cacheability?
Good question. It worked for me, but I guess all powerpc32 can't handle
it.
Shame, as it provides a huge speed up. I suppose an alternative would be
to map the chip twice at different physical addresses, by just configuring
the chip select to be twice the size it should be, and giving them
different cacheability.
Or changing the mapping for writes and then changing it back. It wouldn't
be necessary to change the whole thing, just the page being written to.
next prev parent reply other threads:[~2008-12-16 1:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 18:25 [PATCH] POWERPC: MTD: Add cached map support to physmap_of MTD driver Trent Piepho
2008-12-15 18:30 ` Josh Boyer
2008-12-15 22:56 ` Trent Piepho
2008-12-16 0:21 ` Paul Mackerras
2008-12-16 1:11 ` Trent Piepho [this message]
2008-12-16 8:56 ` Benjamin Herrenschmidt
2008-12-17 21:01 ` Trent Piepho
2008-12-16 8:55 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812151653050.28806@t2.domain.actdsltmp \
--to=tpiepho@freescale.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).