Re: Proposed prom parse fix + moving.

["Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1616 bytes --]

On Fri, 17 Apr 2009, Michal Simek wrote:

> Grant Likely wrote:
> > On Fri, Apr 17, 2009 at 12:08 AM, Michal Simek <monstr@monstr.eu> wrote:
> >> Hi All,
> >>
> >> I have got email from Ilpo about prom_parse file.
> >> I take this file from powerpc. Who did write prom_parse file and take care about?
> > 
> > Posting to the linuxppc-dev list is sufficient to start.  There are
> > several people who may be interested.
> > 
> >> BTW: What about to move prom_parse file to any generic location as we discussed in past?
> >> Any volunteer?
> > 
> > I'm kind of working on it.  More specifically, I'm looking at
> > factoring out fdt stuff into common code (drivers/of/of_fdt.c). But I
> > haven't made a whole lot of progress yet.
> > 
> >> -------- Original Message --------
> >> Subject: [RFC!] [PATCH] microblaze: fix bug in error handling
> >> Date: Thu, 16 Apr 2009 23:05:53 +0300 (EEST)
> >> From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
> >> To: monstr@monstr.eu
> >> CC: microblaze-uclinux@itee.uq.edu.au
> >>
> >> While some version of the patches were on the lkml I read
> >> some part of the code briefly through but my feedback got
> >> stuck into postponed emails, so here's one correctness
> >> related issue I might have found (the rest were just
> >> cosmetic things).
> >>
> >> I'm not sure if the latter return needs the of_node_put or not
> >> but it seems more likely than not.
> > 
> > Yes, it does.  This change is applicable to
> > arch/powerpc/kernel/prom_parse.c too.
> 
> ok.
> Ilpo: Can you create patch for both architectures?

Sure, but tomorrow as today is a deadline day :-).

-- 
 i.