From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55280C433DB for ; Tue, 5 Jan 2021 03:04:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D66822573 for ; Tue, 5 Jan 2021 03:04:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D66822573 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4D8y5B0xKxzDqW3 for ; Tue, 5 Jan 2021 14:04:14 +1100 (AEDT) Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4D8y3P0SGFzDqTp for ; Tue, 5 Jan 2021 14:02:41 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lunn.ch Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by ozlabs.org (Postfix) with ESMTP id 4D8y3N6v1bz9sVs for ; Tue, 5 Jan 2021 14:02:40 +1100 (AEDT) Received: by ozlabs.org (Postfix) id 4D8y3N6MxGz9sVr; Tue, 5 Jan 2021 14:02:40 +1100 (AEDT) Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lunn.ch (client-ip=185.16.172.187; helo=vps0.lunn.ch; envelope-from=andrew@lunn.ch; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=lunn.ch X-Greylist: delayed 1385 seconds by postgrey-1.36 at bilbo; Tue, 05 Jan 2021 14:02:40 AEDT Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4D8y3N5KNnz9sVq; Tue, 5 Jan 2021 14:02:40 +1100 (AEDT) Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kwcFr-00G4Zi-QU; Tue, 05 Jan 2021 03:39:27 +0100 Date: Tue, 5 Jan 2021 03:39:27 +0100 From: Andrew Lunn To: Michael Ellerman Subject: Re: [PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE Message-ID: References: <20210105022229.54601-1-mpe@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105022229.54601-1-mpe@ellerman.id.au> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, kuba@kernel.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o > ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-bitbang.o > > Add the missing MODULE_LICENSEs to fix the build. Both files include a > copyright header indicating they are GPL v2. > > Signed-off-by: Michael Ellerman > --- > drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 1 + > drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c > index c8e5d889bd81..76ac1a9eab58 100644 > --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c > +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c > @@ -223,3 +223,4 @@ static struct platform_driver fs_enet_bb_mdio_driver = { > }; > > module_platform_driver(fs_enet_bb_mdio_driver); > +MODULE_LICENSE("GPL v2"); > diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c > index 8b51ee142fa3..407c330b432f 100644 > --- a/drivers/net/ethernet/freescale/fs_enet/mii-fec.c > +++ b/drivers/net/ethernet/freescale/fs_enet/mii-fec.c > @@ -224,3 +224,4 @@ static struct platform_driver fs_enet_fec_mdio_driver = { > }; > > module_platform_driver(fs_enet_fec_mdio_driver); > +MODULE_LICENSE("GPL v2"); Hi Michael The use of "GPL v2" has been deprecated. Please use just "GPL". There is a discussion about this here: https://lore.kernel.org/patchwork/patch/1036331/ https://www.kernel.org/doc/html/latest/process/license-rules.html#id1 Andrew