From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F0FBC4332F for ; Tue, 18 Oct 2022 06:09:54 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ms3Nw205Pz3cDb for ; Tue, 18 Oct 2022 17:09:52 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=NMsal1Yi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=bombadil.srs.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=batv+d635785a9d1969ab94fa+6995+infradead.org+hch@bombadil.srs.infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ms3Mm4B5Lz2xrr for ; Tue, 18 Oct 2022 17:08:48 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HIIqJurEb074qhwvVI9BKHwutRkdsD9nGqA3qOa/1t0=; b=NMsal1YijVUZQbS9PlVs3C2ko1 Ph/ka7cZ/2Uk5CQ/xFzTjrL5G+mP5Q5JSctZEW8lZtBC0sfjp7YJIHXLDvbN46hTQNmoB4XpizT6u rzs4bEXGWAJBuhgSn3e6m1uVqgrBSY6UBJ1YquLYMOsyoAjtfPUTN8B/vLVQAwBB6HD3ww5tp9mO3 3QRBle1s9AmExNdd4SA+ujfpY/IBpVVLGgT+X6mMMNnR8BFAwy/p8qE/WN4ybAwIHSXr9L0S6wP5h 9Snkg1ne05X+JuOqTUYLummNMXL4cbYPaldh8MixI+0q25kgBi8+71To5y7wV6Q0eN5zcPbiORXy2 R9xUmBCQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1okfmF-003DSd-IU; Tue, 18 Oct 2022 06:08:35 +0000 Date: Mon, 17 Oct 2022 23:08:35 -0700 From: Christoph Hellwig To: Jason Gunthorpe , Russell Currey , Oliver O'Halloran , Alexey Kardashevskiy Subject: Re: [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Message-ID: References: <0-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com> <4-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Williamson , Cornelia Huck , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) > #include > #endif > > @@ -689,7 +689,7 @@ void vfio_pci_core_close_device(struct vfio_device *core_vdev) > vdev->sriov_pf_core_dev->vf_token->users--; > mutex_unlock(&vdev->sriov_pf_core_dev->vf_token->lock); > } > -#if IS_ENABLED(CONFIG_VFIO_SPAPR_EEH) > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) So while this preserves the existing behavior, I wonder if checking CONFIG_EEH only would make more sense here.