* Re: [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH [not found] ` <4-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com> @ 2022-10-18 6:08 ` Christoph Hellwig 2022-10-21 19:46 ` Jason Gunthorpe 0 siblings, 1 reply; 2+ messages in thread From: Christoph Hellwig @ 2022-10-18 6:08 UTC (permalink / raw) To: Jason Gunthorpe, Russell Currey, Oliver O'Halloran, Alexey Kardashevskiy Cc: Alex Williamson, Cornelia Huck, linuxppc-dev, kvm > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) > #include <asm/eeh.h> > #endif > > @@ -689,7 +689,7 @@ void vfio_pci_core_close_device(struct vfio_device *core_vdev) > vdev->sriov_pf_core_dev->vf_token->users--; > mutex_unlock(&vdev->sriov_pf_core_dev->vf_token->lock); > } > -#if IS_ENABLED(CONFIG_VFIO_SPAPR_EEH) > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) So while this preserves the existing behavior, I wonder if checking CONFIG_EEH only would make more sense here. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH 2022-10-18 6:08 ` [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Christoph Hellwig @ 2022-10-21 19:46 ` Jason Gunthorpe 0 siblings, 0 replies; 2+ messages in thread From: Jason Gunthorpe @ 2022-10-21 19:46 UTC (permalink / raw) To: Christoph Hellwig Cc: kvm, Alexey Kardashevskiy, Cornelia Huck, Alex Williamson, Oliver O'Halloran, linuxppc-dev On Mon, Oct 17, 2022 at 11:08:35PM -0700, Christoph Hellwig wrote: > > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) > > #include <asm/eeh.h> > > #endif > > > > @@ -689,7 +689,7 @@ void vfio_pci_core_close_device(struct vfio_device *core_vdev) > > vdev->sriov_pf_core_dev->vf_token->users--; > > mutex_unlock(&vdev->sriov_pf_core_dev->vf_token->lock); > > } > > -#if IS_ENABLED(CONFIG_VFIO_SPAPR_EEH) > > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE) > > So while this preserves the existing behavior, I wonder if checking > CONFIG_EEH only would make more sense here. Yes, it does read better, done Thanks, Jason ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-21 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <0-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com>
[not found] ` <4-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com>
2022-10-18 6:08 ` [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Christoph Hellwig
2022-10-21 19:46 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).