From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A209CC433FE for ; Sat, 8 Oct 2022 22:47:57 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MlL182B74z3dwv for ; Sun, 9 Oct 2022 09:47:56 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha256 header.s=20210105 header.b=XGhFZP09; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=srs0=1ou5=2j=zx2c4.com=jason@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=zx2c4.com header.i=@zx2c4.com header.a=rsa-sha256 header.s=20210105 header.b=XGhFZP09; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MlKnP4HRRz3bjD for ; Sun, 9 Oct 2022 09:37:45 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69DE260B14; Sat, 8 Oct 2022 22:37:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DFC7C433C1; Sat, 8 Oct 2022 22:37:35 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="XGhFZP09" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1665268654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KIVWIkgHNJFfTR3APACYr63A/xqCM59y71KVcO4sCaY=; b=XGhFZP09vIl+/5CeKrUwcn8D5G2fzzZUueDyYoC0ioAptMgCsgW2Y/nAMxGX3+Jlr3Pqzf DPqqLFSnwZy5zrGQ0qIoQsckZXAODZVAUr3JPUklU2lLbHkSxIaLy6qBIDsRl1J6fqnfqB i4V7yDQrjT6b8E+OkiJdDj+99/oMH4o= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id c941732b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 8 Oct 2022 22:37:33 +0000 (UTC) Date: Sun, 9 Oct 2022 00:37:33 +0200 From: "Jason A. Donenfeld" To: David Laight Subject: Re: [PATCH v4 4/6] treewide: use get_random_u32() when possible Message-ID: References: <20221007180107.216067-1-Jason@zx2c4.com> <20221007180107.216067-5-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Sun, 09 Oct 2022 09:45:10 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-wireless@vger.kernel.org" , Ulf Hansson , "x86@kernel.org" , Jan Kara , Vignesh Raghavendra , "linux-doc@vger.kernel.org" , Peter Zijlstra , Catalin Marinas , Dave Hansen , "kernel-janitors@vger.kernel.org" , KP Singh , "dri-devel@lists.freedesktop.org" , "patches@lists.linux.dev" , "linux-mm@kvack.org" , Eric Dumazet , "netdev@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "kasan-dev@googlegroups.com" , "H . Peter Anvin" , Andreas Noever , WANG Xuerui , Will Deacon , Christoph Hellwig , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , Mauro Carvalho Chehab , Herbert Xu , Daniel Borkmann , Jonathan Corbet , "linux-rdma@vger.kernel.org" , Helge Deller , Huacai Chen , Hugh Dickins , Russell King , Jozsef Kadlecsik , Jason Gunthorpe , Dave Airlie , Paolo Abeni , "James E . J . Bottomley" , Pablo Neira Ayuso , "linux-media@vger.kernel.org" , Marco Elver , Kees Cook , Yury Norov , Heiko Carstens , Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , "linux-um@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-block@vger.kernel.org" , Richard Weinberger , Borislav Petkov , "linux-nvme@lists.infradead.org" , "loongarch@lists.linux.dev" , Jakub Kicinski , Thomas Gleixner , Andy Shevchenko , Mika Westerberg , Johannes Berg , "linux-arm-kernel@lists.infradead.org" , Jens Axboe , "linux-mmc@vger.kernel.org" , Thomas Bogendoerfer , Theodore Ts'o , "linux-parisc@vger.kernel.org" , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , Florian Westphal , "linux-kernel@vger.kernel.org" , Christoph =?utf-8?Q?B=C3=B6hmwalder?= , Chuck Lever , "linux-crypto@vger.kernel.org" , Jan Kara , Thomas Graf , "linux-fsdevel@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Oct 08, 2022 at 10:18:45PM +0000, David Laight wrote: > From: Jason A. Donenfeld > > Sent: 07 October 2022 19:01 > > > > The prandom_u32() function has been a deprecated inline wrapper around > > get_random_u32() for several releases now, and compiles down to the > > exact same code. Replace the deprecated wrapper with a direct call to > > the real function. The same also applies to get_random_int(), which is > > just a wrapper around get_random_u32(). > > > ... > > diff --git a/net/802/garp.c b/net/802/garp.c > > index f6012f8e59f0..c1bb67e25430 100644 > > --- a/net/802/garp.c > > +++ b/net/802/garp.c > > @@ -407,7 +407,7 @@ static void garp_join_timer_arm(struct garp_applicant *app) > > { > > unsigned long delay; > > > > - delay = (u64)msecs_to_jiffies(garp_join_time) * prandom_u32() >> 32; > > + delay = (u64)msecs_to_jiffies(garp_join_time) * get_random_u32() >> 32; > > mod_timer(&app->join_timer, jiffies + delay); > > } > > > > diff --git a/net/802/mrp.c b/net/802/mrp.c > > index 35e04cc5390c..3e9fe9f5d9bf 100644 > > --- a/net/802/mrp.c > > +++ b/net/802/mrp.c > > @@ -592,7 +592,7 @@ static void mrp_join_timer_arm(struct mrp_applicant *app) > > { > > unsigned long delay; > > > > - delay = (u64)msecs_to_jiffies(mrp_join_time) * prandom_u32() >> 32; > > + delay = (u64)msecs_to_jiffies(mrp_join_time) * get_random_u32() >> 32; > > mod_timer(&app->join_timer, jiffies + delay); > > } > > > > Aren't those: > delay = prandom_u32_max(msecs_to_jiffies(xxx_join_time)); Probably, but too involved and peculiar for this cleanup. Feel free to send a particular patch to that maintainer. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales)