From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: kvm@vger.kernel.org, Alexey Kardashevskiy <aik@ozlabs.ru>,
Cornelia Huck <cohuck@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Oliver O'Halloran <oohall@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH
Date: Fri, 21 Oct 2022 16:46:49 -0300 [thread overview]
Message-ID: <Y1L3KYwWe/reh3TY@nvidia.com> (raw)
In-Reply-To: <Y05C4xT7r+Tz9Jn3@infradead.org>
On Mon, Oct 17, 2022 at 11:08:35PM -0700, Christoph Hellwig wrote:
> > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE)
> > #include <asm/eeh.h>
> > #endif
> >
> > @@ -689,7 +689,7 @@ void vfio_pci_core_close_device(struct vfio_device *core_vdev)
> > vdev->sriov_pf_core_dev->vf_token->users--;
> > mutex_unlock(&vdev->sriov_pf_core_dev->vf_token->lock);
> > }
> > -#if IS_ENABLED(CONFIG_VFIO_SPAPR_EEH)
> > +#if IS_ENABLED(CONFIG_EEH) && IS_ENABLED(CONFIG_VFIO_IOMMU_SPAPR_TCE)
>
> So while this preserves the existing behavior, I wonder if checking
> CONFIG_EEH only would make more sense here.
Yes, it does read better, done
Thanks,
Jason
prev parent reply other threads:[~2022-10-21 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com>
[not found] ` <4-v3-8db96837cdf9+784-vfio_modules_jgg@nvidia.com>
2022-10-18 6:08 ` [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Christoph Hellwig
2022-10-21 19:46 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1L3KYwWe/reh3TY@nvidia.com \
--to=jgg@nvidia.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).