From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CBBCC433FE for ; Sat, 19 Nov 2022 00:22:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NDZ9s3SSPz3f3n for ; Sat, 19 Nov 2022 11:22:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=HlA1H0xw; dkim=fail reason="signature verification failed" header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=54xzcv2k; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linutronix.de (client-ip=2a0a:51c0:0:12e:550::1; helo=galois.linutronix.de; envelope-from=darwi@linutronix.de; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.a=rsa-sha256 header.s=2020 header.b=HlA1H0xw; dkim=pass header.d=linutronix.de header.i=@linutronix.de header.a=ed25519-sha256 header.s=2020e header.b=54xzcv2k; dkim-atps=neutral X-Greylist: delayed 345 seconds by postgrey-1.36 at boromir; Fri, 18 Nov 2022 23:40:12 AEDT Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NDGb03n0rz3c8V for ; Fri, 18 Nov 2022 23:40:12 +1100 (AEDT) Date: Fri, 18 Nov 2022 13:34:12 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668774854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wC43CUGHQ/5Kf6dfYdK3BkocoYb1pAZJ53OoTDcNf8Y=; b=HlA1H0xw89I6mNXZxJfbzjZ9tZMqyfafZ+aFSsNCpLNVFZG4Syb23GWBxogyjR8JsPjoz+ VaJuo4yvuubjsDScFNOYEhnvI/JnS50bh59eCBKM3N2Hq305ykQSGUWvNmepJIi6ASnhEc Egre6BUTheWsCqNBhLfaHD5mXybAE0gZ+FrjXOTtPkHjlj1OyuGGhfr+5pqAEy+A0dS6jh kcjwSSW9Tqj8sV8GpamJiaL4VlNH9fNu7sKS2Z78pFtMLjks7075EQmH7e+rMAWL9esRD6 dFYnvxDpqSenJCJPs1AmOrXBDZqyETwBR2olcWtWGEx6Ik89o+rGvcZQw37D4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668774854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wC43CUGHQ/5Kf6dfYdK3BkocoYb1pAZJ53OoTDcNf8Y=; b=54xzcv2ka0wlcFsUA4oLtl2S4yVRp9s6mDU2H/QJ/HHTk3ITsJRt1buBfx5tYa3HRGPopw Vlw+RnH01UQJ2kAg== From: "Ahmed S. Darwish" To: Bjorn Helgaas Subject: Re: [patch 23/39] PCI/MSI: Move pci_alloc_irq_vectors_affinity() to api.c Message-ID: References: <20221111122014.927531290@linutronix.de> <20221116162322.GA1115421@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116162322.GA1115421@bhelgaas> X-Mailman-Approved-At: Sat, 19 Nov 2022 11:21:11 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pci@vger.kernel.org, Will Deacon , Dan Williams , Lorenzo Pieralisi , Dave Jiang , Ashok Raj , Joerg Roedel , x86@kernel.org, Jason Gunthorpe , Allen Hubbe , Kevin Tian , Jon Mason , linuxppc-dev@lists.ozlabs.org, Alex Williamson , Bjorn Helgaas , Thomas Gleixner , Reinette Chatre , Greg Kroah-Hartman , LKML , Marc Zyngier , Logan Gunthorpe Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Nov 16, 2022 at 10:23:22AM -0600, Bjorn Helgaas wrote: > On Fri, Nov 11, 2022 at 02:54:51PM +0100, Thomas Gleixner wrote: ... > > + > > +/** > > + * pci_alloc_irq_vectors_affinity() - Allocate multiple device interrupt > > + * vectors with affinity requirements > > + * @dev: the PCI device to operate on > > + * @min_vecs: minimum required number of vectors (must be >= 1) > > + * @max_vecs: maximum desired number of vectors > > + * @flags: allocation flags, as in pci_alloc_irq_vectors() > > + * @affd: affinity requirements (can be %NULL). > > + * > > + * Same as pci_alloc_irq_vectors(), but with the extra @affd parameter. > > + * Check that function docs, and &struct irq_affinity, for more details. > > Is "&struct irq_affinity" some kernel-doc syntax, or is the "&" > superfluous? > Hmmm, I stole it from Documentation/doc-guide/kernel-doc.rst. htmldoc parses it and generates a link to the referenced structure's kernel-doc. But, yeah, this was literally the first usage of such a doc pattern in the entire kernel's C code :) Thanks, -- Ahmed S. Darwish Linutronix GmbH