From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Donnellan <ajd@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Frederic Barrat <fbarrat@linux.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] driver core: fix up some missing class.devnode() conversions.
Date: Tue, 29 Nov 2022 09:27:38 +0100 [thread overview]
Message-ID: <Y4XCelSURHMMK61T@kroah.com> (raw)
In-Reply-To: <9da4f875-7fb3-803f-379e-0352eb824d8f@csgroup.eu>
On Tue, Nov 29, 2022 at 06:33:04AM +0000, Christophe Leroy wrote:
>
>
> Le 28/11/2022 à 18:35, Greg Kroah-Hartman a écrit :
> > In commit ff62b8e6588f ("driver core: make struct class.devnode() take a
> > const *") the ->devnode callback changed the pointer to be const, but a
> > few instances of PowerPC drivers were not caught for some reason.
> >
> > Fix this up by changing the pointers to be const.
>
> Build fails:
>
> /linux/arch/powerpc/platforms/book3s/vas-api.c: In function
> 'vas_register_coproc_api':
> /linux/arch/powerpc/platforms/book3s/vas-api.c:590:31: error: assignment
> from incompatible pointer type [-Werror=incompatible-pointer-types]
> coproc_device.class->devnode = coproc_devnode;
> ^
> cc1: all warnings being treated as errors
What did you build this against? It has to be be against my
driver-core-next tree as that is where the Fixes: commit is.
thanks,
greg k-h
next prev parent reply other threads:[~2022-11-29 8:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 17:35 [PATCH] driver core: fix up some missing class.devnode() conversions Greg Kroah-Hartman
2022-11-29 6:33 ` Christophe Leroy
2022-11-29 8:27 ` Greg Kroah-Hartman [this message]
2022-11-29 9:02 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4XCelSURHMMK61T@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ajd@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=fbarrat@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).