From: Petr Mladek <pmladek@suse.com>
To: Song Liu <song@kernel.org>
Cc: jikos@kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
joe.lawrence@redhat.com, Josh Poimboeuf <jpoimboe@redhat.com>,
live-patching@vger.kernel.org, mbenes@suse.cz,
linuxppc-dev@lists.ozlabs.org, jpoimboe@kernel.org
Subject: Re: [PATCH v6] livepatch: Clear relocation targets on a module removal
Date: Fri, 9 Dec 2022 15:20:13 +0100 [thread overview]
Message-ID: <Y5NEHdSSMSyec6S+@alley> (raw)
In-Reply-To: <Y5M+AoKHDK4rn6/i@alley>
On Fri 2022-12-09 14:54:10, Petr Mladek wrote:
> On Mon 2022-11-28 17:57:06, Song Liu wrote:
> > On Fri, Nov 18, 2022 at 8:24 AM Petr Mladek <pmladek@suse.com> wrote:
> > > > --- a/kernel/livepatch/core.c
> > > > +++ b/kernel/livepatch/core.c
> I see that you removed also:
>
> if (strcmp(objname ? objname : "vmlinux", sec_objname))
> return 0;
>
> This is another bug in your "simplification".
This actually is not a bug. It was replaced by the strcmp() check below.
> > > > +
> > > > + if (strcmp(objname, sec_objname))
> > > > + continue;
But this works only because the function is not called for "vmlinux".
It can't be unloaded.
Well, this optimization is not worth it. IMHO, it is better when
the API is able to handle "vmlinux" object a safe way.
We always try to make the livepatch API as error-proof as possible.
It is the main idea of livepatching. It should fix bugs without
breaking the running system.
Best Regards,
Petr
next prev parent reply other threads:[~2022-12-09 14:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 17:12 [PATCH v6] livepatch: Clear relocation targets on a module removal Song Liu
2022-11-17 22:06 ` Song Liu
2022-11-18 16:24 ` Petr Mladek
2022-11-18 17:14 ` Song Liu
2022-11-21 15:32 ` Joe Lawrence
2022-11-21 16:32 ` Song Liu
2022-11-29 1:57 ` Song Liu
2022-12-09 11:41 ` powerpc-part: was: " Petr Mladek
2022-12-09 19:59 ` Song Liu
2022-12-12 17:11 ` Petr Mladek
2022-12-12 22:22 ` Song Liu
2022-12-13 8:13 ` Song Liu
2022-12-13 13:29 ` Petr Mladek
2022-12-13 22:19 ` Joe Lawrence
2022-12-13 19:31 ` Song Liu
2022-12-09 12:36 ` x86 part: " Petr Mladek
2022-12-09 12:49 ` Miroslav Benes
2022-12-09 13:54 ` Petr Mladek
2022-12-09 14:20 ` Petr Mladek [this message]
2022-12-09 18:21 ` Song Liu
2022-12-09 12:55 ` Miroslav Benes
2022-12-09 18:30 ` Song Liu
2022-12-09 18:51 ` Christophe Leroy
2022-12-09 19:24 ` Song Liu
2022-12-12 8:16 ` Miroslav Benes
2022-12-13 8:28 ` Song Liu
2022-12-13 14:37 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5NEHdSSMSyec6S+@alley \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=song@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).