From: Luis Chamberlain <mcgrof@kernel.org>
To: Petr Mladek <pmladek@suse.com>
Cc: "Erhard F ." <erhard_f@mailbox.org>,
Jiri Kosina <jikos@kernel.org>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
kernel test robot <oliver.sang@intel.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
Miroslav Benes <mbenes@suse.cz>,
linuxppc-dev@lists.ozlabs.org,
Josh Poimboeuf <jpoimboe@kernel.org>
Subject: Re: [PATCH] kallsyms: Fix scheduling with interrupts disabled in self-test
Date: Fri, 13 Jan 2023 15:13:03 -0800 [thread overview]
Message-ID: <Y8Hlf68u51j6uLeS@bombadil.infradead.org> (raw)
In-Reply-To: <Y8EZ8+MgMqzu4/7H@alley>
On Fri, Jan 13, 2023 at 09:44:35AM +0100, Petr Mladek wrote:
> On Thu 2023-01-12 10:24:43, Luis Chamberlain wrote:
> > On Thu, Jan 12, 2023 at 08:54:26PM +1000, Nicholas Piggin wrote:
> > > kallsyms_on_each* may schedule so must not be called with interrupts
> > > disabled. The iteration function could disable interrupts, but this
> > > also changes lookup_symbol() to match the change to the other timing
> > > code.
> > >
> > > Reported-by: Erhard F. <erhard_f@mailbox.org>
> > > Link: https://lore.kernel.org/all/bug-216902-206035@https.bugzilla.kernel.org%2F/
> > > Reported-by: kernel test robot <oliver.sang@intel.com>
> > > Link: https://lore.kernel.org/oe-lkp/202212251728.8d0872ff-oliver.sang@intel.com
> > > Fixes: 30f3bb09778d ("kallsyms: Add self-test facility")
> > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > > ---
> >
> > Thanks Nicholas!
> >
> > Petr had just suggested removing this aspect of the selftests, the performance
> > test as its specific to the config, it doesn't run many times to get an
> > average and odd things on a system can create different metrics. Zhen Lei
> > had given up on fixing it and has a patch to instead remove this part of
> > the selftest.
> >
> > I still find value in keeping it, but Petr, would like your opinion on
> > this fix, if we were to keep it.
>
> I am fine with this fix.
Merged the fix. I'll push to Linus for 6.2-rc4
Luis
prev parent reply other threads:[~2023-01-13 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 10:54 [PATCH] kallsyms: Fix scheduling with interrupts disabled in self-test Nicholas Piggin
2023-01-12 17:30 ` Erhard F.
2023-01-12 18:24 ` Luis Chamberlain
2023-01-13 8:44 ` Petr Mladek
2023-01-13 23:13 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Hlf68u51j6uLeS@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=erhard_f@mailbox.org \
--cc=jikos@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=npiggin@gmail.com \
--cc=oliver.sang@intel.com \
--cc=pmladek@suse.com \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).