From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F99AC678D8 for ; Fri, 13 Jan 2023 23:14:23 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Nty0s3FBZz3fCq for ; Sat, 14 Jan 2023 10:14:21 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WK7iL3YG; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=mcgrof@infradead.org; receiver=) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ntxzh2yssz3bNj for ; Sat, 14 Jan 2023 10:13:19 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jUziRo06S+js26H0jEpikXECL+w+QlE/tWgpvgKsJA8=; b=WK7iL3YGO+YC4BSfnnwIJipBHy L/yPKa4Wr0ZWL0FxqZ4DMXCmcSA834QgpGSqZtyLNYRZA8jivE9DJxUqyBuG9l4FM5zI6xtv2K3SI rGHWNJJ33ufC97ZdHQKV2ujRZncan0nEeksdy/S5mv3orNTlVOFAy9t/FgGEdlKFFU3n+Xvk28Toq rzD/lU9k8vnuHybnkfompq2/ms5KQwcWJCKfQfj0ee/TlfJUWgTWTUP5s8QRS+KVgKhCr7ZL/ArAx qLjUSsDiJljaYfakgu8WFdxQapJOQdKNQgK2pP/4Vygvmp6gN/lrfIXRIgEwqfL7KWC84G9cAFvPK 9EArjXew==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGTEN-004nM8-VM; Fri, 13 Jan 2023 23:13:03 +0000 Date: Fri, 13 Jan 2023 15:13:03 -0800 From: Luis Chamberlain To: Petr Mladek Subject: Re: [PATCH] kallsyms: Fix scheduling with interrupts disabled in self-test Message-ID: References: <20230112105426.1037325-1-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Erhard F ." , Jiri Kosina , linux-kernel@vger.kernel.org, Nicholas Piggin , kernel test robot , Zhen Lei , Miroslav Benes , linuxppc-dev@lists.ozlabs.org, Josh Poimboeuf Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jan 13, 2023 at 09:44:35AM +0100, Petr Mladek wrote: > On Thu 2023-01-12 10:24:43, Luis Chamberlain wrote: > > On Thu, Jan 12, 2023 at 08:54:26PM +1000, Nicholas Piggin wrote: > > > kallsyms_on_each* may schedule so must not be called with interrupts > > > disabled. The iteration function could disable interrupts, but this > > > also changes lookup_symbol() to match the change to the other timing > > > code. > > > > > > Reported-by: Erhard F. > > > Link: https://lore.kernel.org/all/bug-216902-206035@https.bugzilla.kernel.org%2F/ > > > Reported-by: kernel test robot > > > Link: https://lore.kernel.org/oe-lkp/202212251728.8d0872ff-oliver.sang@intel.com > > > Fixes: 30f3bb09778d ("kallsyms: Add self-test facility") > > > Signed-off-by: Nicholas Piggin > > > --- > > > > Thanks Nicholas! > > > > Petr had just suggested removing this aspect of the selftests, the performance > > test as its specific to the config, it doesn't run many times to get an > > average and odd things on a system can create different metrics. Zhen Lei > > had given up on fixing it and has a patch to instead remove this part of > > the selftest. > > > > I still find value in keeping it, but Petr, would like your opinion on > > this fix, if we were to keep it. > > I am fine with this fix. Merged the fix. I'll push to Linus for 6.2-rc4 Luis