From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Laight <David.Laight@aculab.com>
Cc: "irogers@google.com" <irogers@google.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"maddy@linux.ibm.com" <maddy@linux.ibm.com>,
"rnsastry@linux.ibm.com" <rnsastry@linux.ibm.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
'Athira Rajeev' <atrajeev@linux.vnet.ibm.com>,
"james.clark@arm.com" <james.clark@arm.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"kjain@linux.ibm.com" <kjain@linux.ibm.com>,
"namhyung@kernel.org" <namhyung@kernel.org>,
"disgoel@linux.ibm.com" <disgoel@linux.ibm.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH V3] tools/perf/tests: Fix string substitutions in build id test
Date: Fri, 20 Jan 2023 11:29:19 -0300 [thread overview]
Message-ID: <Y8qlP+mmgW0M80u3@kernel.org> (raw)
In-Reply-To: <8c433a543cda48e5b736312903355918@AcuMS.aculab.com>
Em Fri, Jan 20, 2023 at 08:51:59AM +0000, David Laight escreveu:
> From: Arnaldo Carvalho de Melo
> > Sent: 19 January 2023 17:00
> >
> > Em Thu, Jan 19, 2023 at 03:49:15PM +0000, David Laight escreveu:
> > > From: Athira Rajeev
> > > > Sent: 19 January 2023 14:27
> > > ...
> > > > The test script "tests/shell/buildid.sh" uses some of the
> > > > string substitution ways which are supported in bash, but not in
> > > > "sh" or other shells. Above error on line number 69 that reports
> > > > "Bad substitution" is:
> > >
> > > Looks better - assuming it works :-)
> >
> > :-)
> >
> > Can I take this as an:
> >
> > Acked-by: David Laight <David.Laight@ACULAB.COM>
>
> I'm not sure that is worth anything.
> You can add a Reviewed-by
Thanks, I'll then add:
Reviewed-by: David Laight <David.Laight@ACULAB.COM>
- Arnaldo
next prev parent reply other threads:[~2023-01-20 14:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 14:27 [PATCH V3] tools/perf/tests: Fix string substitutions in build id test Athira Rajeev
2023-01-19 15:49 ` David Laight
2023-01-19 16:59 ` Arnaldo Carvalho de Melo
2023-01-20 8:51 ` David Laight
2023-01-20 14:29 ` Arnaldo Carvalho de Melo [this message]
2023-01-20 7:16 ` Disha Goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8qlP+mmgW0M80u3@kernel.org \
--to=acme@kernel.org \
--cc=David.Laight@aculab.com \
--cc=ak@linux.intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=disgoel@linux.ibm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kjain@linux.ibm.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=namhyung@kernel.org \
--cc=rnsastry@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).