From: Matthew Wilcox <willy@infradead.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: michel@lespinasse.org, nvdimm@lists.linux.dev, heiko@sntech.de,
leewalsh@google.com, dri-devel@lists.freedesktop.org,
perex@perex.cz, jglisse@google.com, arjunroy@google.com,
m.szyprowski@samsung.com, linux-arch@vger.kernel.org,
qianweili@huawei.com, linux-samsung-soc@vger.kernel.org,
aneesh.kumar@linux.ibm.com, chenhuacai@kernel.org,
kasan-dev@googlegroups.com, linux-acpi@vger.kernel.org,
rientjes@google.com, xen-devel@lists.xenproject.org,
devel@lists.orangefs.org, robdclark@gmail.com,
minchan@google.com, robert.jarzmik@free.fr,
linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org,
npiggin@gmail.com, alex.williamson@redhat.com,
viro@zeniv.linux.org.uk, luto@kernel.org, gthelen@google.com,
tglx@linutronix.de, ldufour@linux.ibm.com,
Suren Baghdasaryan <surenb@google.com>,
linux-sgx@vger.kernel.org, martin.petersen@oracle.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-fsdevel@vger.kernel.or g, akpm@linux-foundation.org,
linux-media@vger.kernel.org, freedreno@lists.freedesktop.org,
joelaf@google.com, linux-aio@kvack.org,
linux-fbdev@vger.kernel.org, linux-ia64@vger.kernel.org,
david@redhat.com, dave.hansen@linux.intel.com,
virtualization@lists.linux-foundation.org, edumazet@google.com,
target-devel@vger.kernel.org, punit.agrawal@bytedance.com,
linux-s390@vger.kernel.org, dave@stgolabs.net, deller@gmx.de,
hughd@google.com, andrii@kernel.org,
patrik.r.jakobsson@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-rockchip@lists.infradead.org,
linux-graphics-maintainer@vmware.com, kernel-team@android.com,
jayalk@intworks.biz, soheil@google.com, selinux@vger.kernel.org,
linux-arm-msm@vger.kernel.org, mripard@kernel.org,
shakeelb@google.com, haojian.zhuang@gmail.com,
loongarch@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
tytso@mit.edu, nico@fluxnic.net, muchun.song@linux.dev,
hjc@rock-chips.com, mcoquelin.stm32@gmail.com,
tatashin@google.com, mike.kravetz@ora cle.com,
songliubraving@fb.com, jasowang@redhat.com,
alsa-devel@alsa-project.org, peterx@redhat.com,
linux-tegra@vger.kernel.org, kraxel@redhat.com, will@kernel.org,
dmaengine@vger.kernel.org, bhe@redhat.com, miklos@szeredi.hu,
linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev,
amd-gfx@lists.freedesktop.org, gurua@google.com,
dgilbert@interlog.com, xiang@kernel.org, pabeni@redhat.com,
jejb@linux.ibm.com, quic_abhinavk@quicinc.com, bp@alien8.de,
mchehab@kernel.org, linux-ext4@vger.kernel.org, tomba@kernel.org,
hughlynch@google.com, sre@kernel.org, tfiga@chromium.org,
linux-xfs@vger.kernel.org, zhangfei.gao@linaro.org,
wangzhou1@hisilicon.com, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-erofs@lists.ozlabs.org,
davem@davemloft.net, mhocko@suse.com, kvm@vger.kernel.org,
mst@redhat.com, peterz@infradead.org, bigeasy@linutronix.de,
alexandre.torgue@foss.st.com, dhowells@redhat.com,
linux-mm@kvack.org, ray.huang@amd.com, adilger.kernel@dilger.ca,
kuba@kernel.org, sparclinux@ vger.kernel.org, airlied@gmail.com,
anton.ivanov@cambridgegreys.com, herbert@gondor.apana.org.au,
linux-scsi@vger.kernel.org, richard@nod.at, x86@kernel.org,
vkoul@kernel.org, mingo@redhat.com, axelrasmussen@google.com,
intel-gfx@lists.freedesktop.org, daniel@ffwll.ch,
paulmck@kernel.org, jannh@google.com, chao@kernel.org,
maarten.lankhorst@linux.intel.com, liam.howlett@oracle.com,
hdegoede@redhat.com, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, vbabka@suse.cz, dimitri.sivanich@hpe.com,
posk@google.com, lstoakes@gmail.com, peterjung1337@gmail.com,
yoshfuji@linux-ipv6.org, linuxppc-dev@lists.ozlabs.org,
dsahern@kernel.org, kent.overstreet@linux.dev,
kexec@lists.infradead.org, tiwai@suse.com,
krzysztof.kozlowski@linaro.org, tzimmermann@suse.de,
hannes@cmpxchg.org, dmitry.baryshkov@linaro.org,
johannes@sipsolutions.net, mgorman@techsingularity.net,
linux-accelerators@lists.ozlabs.org, l.stach@pengutronix.de
Subject: Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions
Date: Thu, 26 Jan 2023 15:09:00 +0000 [thread overview]
Message-ID: <Y9KXjLaFFUvqqdd4@casper.infradead.org> (raw)
In-Reply-To: <Y9KTUw/04FmBVplw@kernel.org>
On Thu, Jan 26, 2023 at 04:50:59PM +0200, Mike Rapoport wrote:
> On Thu, Jan 26, 2023 at 11:17:09AM +0200, Mike Rapoport wrote:
> > On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:
> > > +/* Use when VMA is not part of the VMA tree and needs no locking */
> > > +static inline void init_vm_flags(struct vm_area_struct *vma,
> > > + unsigned long flags)
> >
> > I'd suggest to make it vm_flags_init() etc.
>
> Thinking more about it, it will be even clearer to name these vma_flags_xyz()
Perhaps vma_VERB_flags()?
vma_init_flags()
vma_reset_flags()
vma_set_flags()
vma_clear_flags()
vma_mod_flags()
next prev parent reply other threads:[~2023-01-27 2:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 8:38 [PATCH v2 0/6] introduce vm_flags modifier functions Suren Baghdasaryan
2023-01-25 8:38 ` [PATCH v2 1/6] mm: introduce vma->vm_flags " Suren Baghdasaryan
2023-01-25 8:56 ` Michal Hocko
2023-01-25 9:09 ` Peter Zijlstra
2023-01-25 16:49 ` Suren Baghdasaryan
2023-01-25 18:37 ` Matthew Wilcox
2023-01-25 19:21 ` Suren Baghdasaryan
2023-01-25 18:33 ` Matthew Wilcox
2023-01-25 19:22 ` Suren Baghdasaryan
2023-01-26 9:17 ` Mike Rapoport
2023-01-26 14:50 ` Mike Rapoport
2023-01-26 15:09 ` Matthew Wilcox [this message]
2023-01-26 16:25 ` Suren Baghdasaryan
2023-01-25 8:38 ` [PATCH v2 2/6] mm: replace VM_LOCKED_CLEAR_MASK with VM_LOCKED_MASK Suren Baghdasaryan
2023-01-25 9:02 ` Michal Hocko
2023-01-26 9:19 ` Mike Rapoport
2023-01-25 8:38 ` [PATCH v2 3/6] mm: replace vma->vm_flags direct modifications with modifier calls Suren Baghdasaryan
2023-01-25 9:30 ` Michal Hocko
2023-01-25 16:55 ` Suren Baghdasaryan
2023-01-26 9:21 ` Mike Rapoport
2023-01-26 17:07 ` Sebastian Reichel
2023-01-25 8:38 ` [PATCH v2 4/6] mm: replace vma->vm_flags indirect modification in ksm_madvise Suren Baghdasaryan
2023-01-25 9:38 ` Michal Hocko
2023-01-25 16:57 ` Suren Baghdasaryan
2023-01-25 17:08 ` Michal Hocko
2023-01-25 17:22 ` Suren Baghdasaryan
2023-01-26 9:26 ` Mike Rapoport
2023-01-25 8:38 ` [PATCH v2 5/6] mm: introduce mod_vm_flags_nolock and use it in untrack_pfn Suren Baghdasaryan
2023-01-25 9:42 ` Michal Hocko
2023-01-25 17:00 ` Suren Baghdasaryan
2023-01-26 9:34 ` Mike Rapoport
2023-01-25 8:38 ` [PATCH v2 6/6] mm: export dump_mm() Suren Baghdasaryan
2023-01-25 9:43 ` Michal Hocko
2023-01-26 14:48 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KXjLaFFUvqqdd4@casper.infradead.org \
--to=willy@infradead.org \
--cc=alex.williamson@redhat.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arjunroy@google.com \
--cc=chenhuacai@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=gthelen@google.com \
--cc=heiko@sntech.de \
--cc=jglisse@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=ldufour@linux.ibm.com \
--cc=leewalsh@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.or \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=luto@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=michel@lespinasse.org \
--cc=minchan@google.com \
--cc=npiggin@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=perex@perex.cz \
--cc=qianweili@huawei.com \
--cc=rientjes@google.com \
--cc=robdclark@gmail.com \
--cc=robert.jarzmik@free.fr \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).