From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Douglas Anderson <dianders@chromium.org>,
Paul Mackerras <paulus@samba.org>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Jordan Niethe <jniethe5@gmail.com>, Wei Li <liwei391@huawei.com>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
Kees Cook <keescook@chromium.org>,
Alistair Popple <alistair@popple.id.au>,
Steven Rostedt <rostedt@goodmis.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Nicholas Piggin <npiggin@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sumit Garg <sumit.garg@linaro.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Jason Wessel <jason.wessel@windriver.com>,
kgdb-bugreport@lists.sourceforge.net,
linuxppc-dev@lists.ozlabs.org, Mike Rapoport <rppt@kernel.org>
Subject: Re: [PATCH next v3 11/15] printk: kmsg_dumper: remove @active field
Date: Mon, 1 Mar 2021 18:09:23 +0100 [thread overview]
Message-ID: <YD0fw0DErfsi2ibs@alley> (raw)
In-Reply-To: <20210225202438.28985-12-john.ogness@linutronix.de>
On Thu 2021-02-25 21:24:34, John Ogness wrote:
> All 6 kmsg_dumpers do not benefit from the @active flag:
>
> (provide their own synchronization)
> - arch/powerpc/kernel/nvram_64.c
> - arch/um/kernel/kmsg_dump.c
> - drivers/mtd/mtdoops.c
> - fs/pstore/platform.c
>
> (only dump on KMSG_DUMP_PANIC, which does not require
> synchronization)
> - arch/powerpc/platforms/powernv/opal-kmsg.c
> - drivers/hv/vmbus_drv.c
>
> The other 2 kmsg_dump users also do not rely on @active:
>
> (hard-code @active to always be true)
> - arch/powerpc/xmon/xmon.c
> - kernel/debug/kdb/kdb_main.c
Great summary!
> Therefore, @active can be removed.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2021-03-01 17:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 20:24 [PATCH next v3 00/15] printk: remove logbuf_lock John Ogness
2021-02-25 20:24 ` [PATCH next v3 11/15] printk: kmsg_dumper: remove @active field John Ogness
2021-03-01 17:09 ` Petr Mladek [this message]
2021-02-25 20:24 ` [PATCH next v3 12/15] printk: introduce a kmsg_dump iterator John Ogness
2021-02-25 21:59 ` Kees Cook
2021-02-26 7:59 ` John Ogness
2021-03-01 18:07 ` Petr Mladek
2021-03-02 13:20 ` John Ogness
2021-03-02 13:55 ` Petr Mladek
2021-02-25 20:24 ` [PATCH next v3 14/15] printk: kmsg_dump: remove _nolock() variants John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD0fw0DErfsi2ibs@alley \
--to=pmladek@suse.com \
--cc=alistair@popple.id.au \
--cc=daniel.thompson@linaro.org \
--cc=dave@stgolabs.net \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=jniethe5@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=keescook@chromium.org \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liwei391@huawei.com \
--cc=maddy@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=paulus@samba.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=sumit.garg@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).