From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 099FFC433E0 for ; Mon, 1 Mar 2021 17:24:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D937964ED6 for ; Mon, 1 Mar 2021 17:24:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D937964ED6 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Dq6Yx2mhtz3clS for ; Tue, 2 Mar 2021 04:24:05 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=susede1 header.b=RqQ5wOe0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.com (client-ip=195.135.220.15; helo=mx2.suse.de; envelope-from=pmladek@suse.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=susede1 header.b=RqQ5wOe0; dkim-atps=neutral X-Greylist: delayed 849 seconds by postgrey-1.36 at boromir; Tue, 02 Mar 2021 04:23:40 AEDT Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Dq6YS5Qw8z30PK for ; Tue, 2 Mar 2021 04:23:39 +1100 (AEDT) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1614618565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H35nz79U3iTc666xWR8lPmhHegrvhs5FWA9WuA5DkEI=; b=RqQ5wOe0/iOPbgkCB6+F3wjB6c0eOIYiAodwUelOlBKkvKla4T6I47dITleDs6+RLWIspc Es21DW2KUJVlAfVhSegO/4+EAe2vuEUr39OyN6XxmJfp4q/GBF6Pnh5R6EkEnA3PcrwpfB JyUEYKEYJ1KY7x0yNXuizUFDOpdNCiw= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8FB08AE3C; Mon, 1 Mar 2021 17:09:25 +0000 (UTC) Date: Mon, 1 Mar 2021 18:09:23 +0100 From: Petr Mladek To: John Ogness Subject: Re: [PATCH next v3 11/15] printk: kmsg_dumper: remove @active field Message-ID: References: <20210225202438.28985-1-john.ogness@linutronix.de> <20210225202438.28985-12-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225202438.28985-12-john.ogness@linutronix.de> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sergey Senozhatsky , Douglas Anderson , Paul Mackerras , Pavel Tatashin , Daniel Thompson , Madhavan Srinivasan , Jordan Niethe , Wei Li , Ravi Bangoria , Kees Cook , Alistair Popple , Steven Rostedt , Davidlohr Bueso , Nicholas Piggin , Thomas Gleixner , Sumit Garg , linux-kernel@vger.kernel.org, Sergey Senozhatsky , Jason Wessel , kgdb-bugreport@lists.sourceforge.net, linuxppc-dev@lists.ozlabs.org, Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu 2021-02-25 21:24:34, John Ogness wrote: > All 6 kmsg_dumpers do not benefit from the @active flag: > > (provide their own synchronization) > - arch/powerpc/kernel/nvram_64.c > - arch/um/kernel/kmsg_dump.c > - drivers/mtd/mtdoops.c > - fs/pstore/platform.c > > (only dump on KMSG_DUMP_PANIC, which does not require > synchronization) > - arch/powerpc/platforms/powernv/opal-kmsg.c > - drivers/hv/vmbus_drv.c > > The other 2 kmsg_dump users also do not rely on @active: > > (hard-code @active to always be true) > - arch/powerpc/xmon/xmon.c > - kernel/debug/kdb/kdb_main.c Great summary! > Therefore, @active can be removed. > > Signed-off-by: John Ogness Reviewed-by: Petr Mladek Best Regards, Petr