From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C988BC433B4 for ; Tue, 6 Apr 2021 14:40:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F08B7613C4 for ; Tue, 6 Apr 2021 14:40:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F08B7613C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FF9D05dd3z30Cs for ; Wed, 7 Apr 2021 00:40:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SlT7S0jf; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=rppt@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=SlT7S0jf; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FF9CY6Nj9z2y08 for ; Wed, 7 Apr 2021 00:39:37 +1000 (AEST) Received: by mail.kernel.org (Postfix) with ESMTPSA id B468961041; Tue, 6 Apr 2021 14:39:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617719974; bh=G2BOVus52Iqv5BWziu8fp8dbl+kVdMy8pIchFSY+N7Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SlT7S0jfOQB0ipW94M+9K780g98fCxdRJ2QJSXci+Rly0qaDQCHFeXHTOsI463Xi7 S70I+/1OXQBcTfcIkIpl67B5zXSuZCsFVQzUBPU8aiRkhXqG4+Gr/kX784jry6UKjU t/VEsOeLGhmj1jkbfR4iAG4mFD+vamcJPKxJMUcvNbOJ2RhmbWIpBgjpUvC0BANEGE vr4AodXPx2i9E03UI+pPMK1LRyEpkXwf1hJUOL/xYCdBgDtehTwHpHwy3IOxolwkOe Eefs8HR/7P44p9cGBhR5ZazQeydf2U0negBr9o85K3dg0zDsONcgGw+lFDOTompGZC fzX5/aFjCjwKQ== Date: Tue, 6 Apr 2021 17:39:15 +0300 From: Mike Rapoport To: Andy Shevchenko Subject: Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers Message-ID: References: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406133158.73700-1-andriy.shevchenko@linux.intel.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , linux-hyperv@vger.kernel.org, Tetsuo Handa , linux-remoteproc@vger.kernel.org, Bjorn Andersson , Paul Mackerras , "H. Peter Anvin" , Joel Fernandes , "K. Y. Srinivasan" , Thomas Gleixner , linux-arch@vger.kernel.org, Wei Liu , Stephen Hemminger , Corey Minyard , x86@kernel.org, Ingo Molnar , Iurii Zaikin , Ohad Ben-Cohen , Joerg Roedel , Kees Cook , "Paul E. McKenney" , Lai Jiangshan , Haiyang Zhang , Josh Triplett , "Steven Rostedt \(VMware\)" , rcu@vger.kernel.org, Borislav Petkov , openipmi-developer@lists.sourceforge.net, Michael Kelley , Vlastimil Babka , Mathieu Poirier , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Arnd Bergmann , Eric Biederman , linux-fsdevel@vger.kernel.org, Mathieu Desnoyers , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > At the same time convert users in header and lib folder to use new header. > Though for time being include new header back to kernel.h to avoid twisted > indirected includes for existing users. > > Signed-off-by: Andy Shevchenko Acked-by: Mike Rapoport > --- > arch/powerpc/kernel/setup-common.c | 1 + > arch/x86/include/asm/desc.h | 1 + > arch/x86/kernel/cpu/mshyperv.c | 1 + > arch/x86/kernel/setup.c | 1 + > drivers/char/ipmi/ipmi_msghandler.c | 1 + > drivers/remoteproc/remoteproc_core.c | 1 + > include/asm-generic/bug.h | 3 +- > include/linux/kernel.h | 84 +----------------------- > include/linux/panic.h | 98 ++++++++++++++++++++++++++++ > include/linux/panic_notifier.h | 12 ++++ > kernel/hung_task.c | 1 + > kernel/kexec_core.c | 1 + > kernel/panic.c | 1 + > kernel/rcu/tree.c | 2 + > kernel/sysctl.c | 1 + > kernel/trace/trace.c | 1 + > 16 files changed, 126 insertions(+), 84 deletions(-) > create mode 100644 include/linux/panic.h > create mode 100644 include/linux/panic_notifier.h > > diff --git a/arch/x86/include/asm/desc.h b/arch/x86/include/asm/desc.h > index 476082a83d1c..ceb12683b6d1 100644 > --- a/arch/x86/include/asm/desc.h > +++ b/arch/x86/include/asm/desc.h > @@ -9,6 +9,7 @@ > #include > #include > > +#include This seems unrelated, but I might be missing something. > #include > #include > -- Sincerely yours, Mike.