[PATCH 00/21] Rid W=1 warnings from IDE

[PATCH 00/21] Rid W=1 warnings from IDE

[Lee Jones]

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Lee Jones (21):
  ide: alim15x3: Document alim15x3_init_one()'s 'id' param
  ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param
  ide: ide-dma-sff: Provide some missing 'param' descriptions
  ide: ide-io: Fix a few kernel-doc misdemeanours
  ide: ide-proc: Strip out unused fops structure and accompanying
    call-back
  ide: cs5530: Fix incorrect documentation for function
    init_chipset_cs5530()
  ide: ide-probe: Fix-up incorrectly documented function
    probe_for_drive()
  ide: hpt366: Provide some missing descriptions for 'f_{low,high}'
  ide: piix: Remove unused variable 'sitre'
  ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s
    'value' param
  ide: slc90e66: Remove unused variable 'sitre'
  ide: it821x: Fix a couple of incorrectly documented functions
  ide: siimage: Fix some incorrectly documented functions/params
  ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param
  ide: ide-cd_ioctl: Remove unused variable 'stat'
  ide: ide-cd: Demote kernel-doc abuse
  ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused
  ide: ide-io: Document ide_intr()'s param 'irq'
  ide: piix: Fix incorrectly documented param 'hwif'
  ide: ide-acpi: Provide missing description for param 'obj_loc'
  ide: pmac: Staticise local function 'pmac_ide_probe'

 drivers/ide/alim15x3.c     |  1 +
 drivers/ide/cs5530.c       |  2 +-
 drivers/ide/hpt366.c       |  2 ++
 drivers/ide/ide-acpi.c     |  4 +++-
 drivers/ide/ide-cd.c       |  2 +-
 drivers/ide/ide-cd_ioctl.c |  3 +--
 drivers/ide/ide-dma-sff.c  |  4 ++++
 drivers/ide/ide-dma.c      |  1 +
 drivers/ide/ide-io.c       |  9 +++++----
 drivers/ide/ide-probe.c    |  2 +-
 drivers/ide/ide-proc.c     | 13 -------------
 drivers/ide/it821x.c       |  4 ++--
 drivers/ide/pdc202xx_new.c |  1 +
 drivers/ide/piix.c         |  4 +---
 drivers/ide/pmac.c         |  2 +-
 drivers/ide/siimage.c      |  4 ++--
 drivers/ide/slc90e66.c     |  3 +--
 drivers/ide/via82cxxx.c    |  2 +-
 18 files changed, 29 insertions(+), 34 deletions(-)

Cc: Adrian Sun <a.sun@sun.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andre Hedrick <andre@linux-ide.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Benoit Poulot-Cazajous <poulot@chorus.fr>
Cc: Christian Brunner <chb@muc.de>
Cc: "Christopher J. Reimer" <reimer@doe.carleton.ca>
Cc: CJ <cjtsai@ali.com.tw>
Cc: Clear Zhang <Clear.Zhang@ali.com.tw>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Duncan Laurie <void@sun.com>
Cc: Erik Andersen <andersee@debian.org>
Cc: Frank Tiernan <frankt@promise.com>
Cc: Gadi Oxman <gadio@netvision.net.il>
Cc: Jens Axboe <axboe@suse.de>
Cc: linux-ide@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Mark Lord <mlord@pobox.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mike Waychison <crlf@sun.com>
Cc: or <source@mvista.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Robert Bringman <rob@mars.trion.com>
Cc: Scott Snyder <snyder@fnald0.fnal.gov>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: "Software, Inc" <source@mvista.com>
Cc: support to <linux-ide@vger.kernel.org>
Cc: Tim Hockin <thockin@sun.com>
-- 
2.31.1

[PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe'

[Lee Jones]

Fixes the following W=1 kernel build warning(s):

 drivers/ide/pmac.c:1418:12: warning: no previous prototype for ‘pmac_ide_probe’ [-Wmissing-prototypes]

Cc: "David S. Miller" <davem@davemloft.net>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: linux-ide@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ide/pmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index ea0b064b5f56b..d51a2e252b6f2 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -1415,7 +1415,7 @@ static struct pci_driver pmac_ide_pci_driver = {
 };
 MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match);
 
-int __init pmac_ide_probe(void)
+static int __init pmac_ide_probe(void)
 {
 	int error;
 
-- 
2.31.1

Re: [PATCH 00/21] Rid W=1 warnings from IDE

[Christoph Hellwig]

Please don't touch this code as it is about to be removed entirely.

Re: [PATCH 00/21] Rid W=1 warnings from IDE

[Lee Jones]

On Mon, 07 Jun 2021, Christoph Hellwig wrote:

> Please don't touch this code as it is about to be removed entirely.

Do you have an ETA for this work?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 00/21] Rid W=1 warnings from IDE

[Christoph Hellwig]

On Mon, Jun 14, 2021 at 10:12:28AM +0100, Lee Jones wrote:
> On Mon, 07 Jun 2021, Christoph Hellwig wrote:
> 
> > Please don't touch this code as it is about to be removed entirely.
> 
> Do you have an ETA for this work?

I just resent the series.