From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org,
Oliver O'Halloran <oohall@gmail.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/1] powerpc/papr_scm: Properly handle UUID types and API
Date: Wed, 16 Jun 2021 17:05:10 +0300 [thread overview]
Message-ID: <YMoFFn3J+eUzkUYh@smile.fi.intel.com> (raw)
In-Reply-To: <6f895afd-3469-c330-a4da-72db89dba6b3@linux.ibm.com>
On Wed, Jun 16, 2021 at 07:17:03PM +0530, Aneesh Kumar K.V wrote:
> On 6/16/21 7:13 PM, Andy Shevchenko wrote:
> > Parse to and export from UUID own type, before dereferencing.
> > This also fixes wrong comment (Little Endian UUID is something else)
> > and should eliminate the direct strict types assignments.
> >
> > Fixes: 43001c52b603 ("powerpc/papr_scm: Use ibm,unit-guid as the iset cookie")
> > Fixes: 259a948c4ba1 ("powerpc/pseries/scm: Use a specific endian format for storing uuid from the device tree")
>
> Do we need the Fixes: there? It didn't change any functionality right? The
> format with which we stored cookie1 remains the same with older and newer
> code. The newer one is better?
Depends if you are okay with Sparse warnings.
> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Thanks for review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-16 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 13:43 [PATCH v2 1/1] powerpc/papr_scm: Properly handle UUID types and API Andy Shevchenko
2021-06-16 13:47 ` Aneesh Kumar K.V
2021-06-16 14:05 ` Andy Shevchenko [this message]
2021-06-22 12:44 ` Andy Shevchenko
2021-06-22 12:47 ` Andy Shevchenko
2021-06-23 6:03 ` Michael Ellerman
2021-06-25 6:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMoFFn3J+eUzkUYh@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox