From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Alison Schofield" <alison.schofield@intel.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Samuel Iglesias Gonsalvez" <siglesias@igalia.com>,
"Jens Taprogge" <jens.taprogge@taprogge.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Paul Mackerras" <paulus@samba.org>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
"Ira Weiny" <ira.weiny@intel.com>, "Wei Liu" <wei.liu@kernel.org>,
"Alex Dubov" <oakad@ya>, "Dave Jiang" <dave.jiang@intel.com>,
"Maxim Levitsky" <maximlevitsky@gmail.com>,
"Johannes Thumshirn" <morbidrsa@gmail.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
"Helge Deller" <deller@gmx.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Dexuan Cui" <decui@microsoft.com>,
"Russell King" <linux@armlinux.org.uk>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Tom Rix" <trix@redhat.com>,
"Len Brown" <lenb@kernel.org>, "Jiri Kosina" <jikos@kernel.org>,
"Haiyang Zhang" <haiyangz@microsoft.com>,
"Sudeep Holla" <sudeep.holla@arm.com>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Ben Widawsky" <ben.widawsky@intel.com>,
"Moritz Fischer" <mdf@kernel.org>,
"Stephen Hemminger" <sthemmin@microsoft.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Cristian Marussi" <cristian.marussi@arm.com>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Geoff Levand" <geoff@infradead.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel@vger.kernel.org, "Wolfram Sang" <wsa@kernel.org>,
"Vinod Koul" <vkoul@kernel.org>,
"Stefan Richter" <stefanr@s5r6.in-berlin.de>,
kernel@pengutronix.de, "Wu Hao" <hao.wu@intel.com>
Subject: Re: [PATCH] bus: Make remove callback return void
Date: Tue, 6 Jul 2021 14:41:39 +0300 [thread overview]
Message-ID: <YORBc384OjIBC/Yj@kuha.fi.intel.com> (raw)
In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de>
On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote:
> The driver core ignores the return value of this callback because there
> is only little it can do when a device disappears.
>
> This is the final bit of a long lasting cleanup quest where several
> buses were converted to also return void from their remove callback.
> Additionally some resource leaks were fixed that were caused by drivers
> returning an error code in the expectation that the driver won't go
> away.
>
> With struct bus_type::remove returning void it's prevented that newly
> implemented buses return an ignored error code and so don't anticipate
> wrong expectations for driver authors.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
For ulpi and typec:
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
thanks,
--
heikki
next prev parent reply other threads:[~2021-07-06 12:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 9:50 [PATCH] bus: Make remove callback return void Uwe Kleine-König
2021-07-06 9:56 ` Russell King (Oracle)
2021-07-06 10:21 ` Mark Brown
2021-07-06 10:24 ` Chen-Yu Tsai
2021-07-06 10:25 ` Pali Rohár
2021-07-06 10:26 ` Mauro Carvalho Chehab
2021-07-06 10:35 ` Lee Jones
2021-07-06 10:47 ` Johannes Thumshirn
2021-07-06 10:43 ` Alexandre Belloni
2021-07-06 10:45 ` Vinod Koul
2021-07-06 10:46 ` Juergen Gross
2021-07-06 10:49 ` Johan Hovold
2021-07-06 10:57 ` Cornelia Huck
2021-07-06 11:17 ` Cornelia Huck
2021-07-06 12:14 ` Uwe Kleine-König
2021-07-06 11:16 ` Kirti Wankhede
2021-07-06 11:41 ` Heikki Krogerus [this message]
2021-07-06 11:42 ` Maximilian Luz
2021-07-06 14:51 ` Geoff Levand
2021-07-06 15:06 ` Yehezkel Bernat
2021-07-06 15:11 ` Mathieu Poirier
2021-07-06 15:11 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YORBc384OjIBC/Yj@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alison.schofield@intel.com \
--cc=ben.widawsky@intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=cristian.marussi@arm.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=decui@microsoft.com \
--cc=deller@gmx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=geoff@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=hao.wu@intel.com \
--cc=ira.weiny@intel.com \
--cc=jens.taprogge@taprogge.org \
--cc=jernej.skrabec@gmail.com \
--cc=jikos@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maximlevitsky@gmail.com \
--cc=mchehab@kernel.org \
--cc=mdf@kernel.org \
--cc=morbidrsa@gmail.com \
--cc=mripard@kernel.org \
--cc=oakad@ya \
--cc=paulus@samba.org \
--cc=rjw@rjwysocki.net \
--cc=siglesias@igalia.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=sthemmin@microsoft.com \
--cc=sudeep.holla@arm.com \
--cc=trix@redhat.com \
--cc=tsbogend@alpha.franken.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
--cc=vishal.l.verma@intel.com \
--cc=vkoul@kernel.org \
--cc=wei.liu@kernel.org \
--cc=wens@csie.org \
--cc=wsa@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).