From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61B1BC07E96 for ; Tue, 6 Jul 2021 12:54:42 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD6F4619AC for ; Tue, 6 Jul 2021 12:54:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD6F4619AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GK2ZS3ln0z3f5j for ; Tue, 6 Jul 2021 22:54:40 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=heikki.krogerus@linux.intel.com; receiver=) X-Greylist: delayed 124 seconds by postgrey-1.36 at boromir; Tue, 06 Jul 2021 21:45:27 AEST Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GK12b4HFbz2yNf for ; Tue, 6 Jul 2021 21:45:27 +1000 (AEST) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="272945357" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="272945357" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 04:42:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="562991774" Received: from kuha.fi.intel.com ([10.237.72.162]) by fmsmga001.fm.intel.com with SMTP; 06 Jul 2021 04:41:40 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Tue, 06 Jul 2021 14:41:39 +0300 Date: Tue, 6 Jul 2021 14:41:39 +0300 From: Heikki Krogerus To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] bus: Make remove callback return void Message-ID: References: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210706095037.1425211-1-u.kleine-koenig@pengutronix.de> X-Mailman-Approved-At: Tue, 06 Jul 2021 22:48:04 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alison Schofield , Alexander Shishkin , Samuel Iglesias Gonsalvez , Jens Taprogge , Alexandre Belloni , "James E.J. Bottomley" , Benjamin Tissoires , Paul Mackerras , Srinivas Pandruvada , "K. Y. Srinivasan" , Ira Weiny , Wei Liu , Alex Dubov , Dave Jiang , Maxim Levitsky , Johannes Thumshirn , Vishal Verma , Helge Deller , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Dexuan Cui , Russell King , Jernej Skrabec , Chen-Yu Tsai , Tom Rix , Len Brown , Jiri Kosina , Haiyang Zhang , Sudeep Holla , William Breathitt Gray , Maxime Ripard , Ben Widawsky , Moritz Fischer , Stephen Hemminger , Dan Williams , Mauro Carvalho Chehab , Cristian Marussi , Thomas Bogendoerfer , Geoff Levand , Greg Kroah-Hartman , Dmitry Torokhov , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Wolfram Sang , Vinod Koul , Stefan Richter , kernel@pengutronix.de, Wu Hao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König For ulpi and typec: Acked-by: Heikki Krogerus thanks, -- heikki