From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBB7C4338F for ; Thu, 5 Aug 2021 18:55:08 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BDB860F3A for ; Thu, 5 Aug 2021 18:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0BDB860F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ggd8V302cz3dBb for ; Fri, 6 Aug 2021 04:55:06 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GOrV3VP+; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::42f; helo=mail-wr1-x42f.google.com; envelope-from=lee.jones@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=GOrV3VP+; dkim-atps=neutral Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Ggd7y6l5Mz2yyM for ; Fri, 6 Aug 2021 04:54:38 +1000 (AEST) Received: by mail-wr1-x42f.google.com with SMTP id p5so7882903wro.7 for ; Thu, 05 Aug 2021 11:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=GOrV3VP+r8pYdlSiWQTpaesHdYyjntzU0PvvHrN5y3GEyAm/V0Gk6/Q2DVPAjUOuHG cg9PKnXKTT6euec26ur9UeGp7ZJ1lMFf0XKNZ8JHvT1V9wtuX3S5sCHtymzoXEU9qj2q qvrLHR5Nn9+CzXn368JWDViQsPx0sYdfYo81GedinLwzH0j/KWAgMJ76cgcFRANa52Ap k/HeuXbl/H4MM5n9iS0qwck3lV1RsVGsi6ht6u6CHCiFHc0J5dQij11Gxp4rS/NpUOOz xuYYqbl/V2ElVpVt72G3YEr+BRDilwSbeYw+9JCFvZusmxJWVls+zLhfdxvvorH6XeKQ WnMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=mCmxN128wN048rQ3mL+tGyaLgz6ahBPx10bueA4yYQQ=; b=QuWQp/Skt59tuai2KoBozlSa/fdGugT1P09CZa0u6xp4iyYsuXEfX/qQreqd2nG5wR u244DFtXLU60pbBWyquj/xlQCNEH/kYqXyJ0mSvqLjgicQMctaj8azsB7x2PY7zsU5m3 TgSM+curLv8aF9+EOrid+uvZxUDBxE4DHFfWP27lkOAOpF0FG60dGMZpnI4w+yhuuca5 5uaAqs6W5Z7R92uW9SV3aAgS43Ep8kwwPhbgtwGGN/7fh+fjW64SPndDTJjJltOH86ht IRpBxBLJhbBVfI1jtGupaGkrH7MWwkJBpP3l00obXZYzGyzYjw5xXZDMUPPWm4UBUh0+ 5uZw== X-Gm-Message-State: AOAM530JzRuwjLxJPTYPn2jcFpTwXDxCcBbQXpgBZDJGZDlvhgJ3W5NF QTDNb3oqP5rXUYudSvNqTSv1PA== X-Google-Smtp-Source: ABdhPJwssE+mX4OXOdITg+L7JFPUjj2TqXmuwypTLByy6roZIhynzabMmSfypihLZgWIBDpfU85saA== X-Received: by 2002:a5d:5906:: with SMTP id v6mr6899987wrd.194.1628189670642; Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id p5sm7799843wrd.25.2021.08.05.11.54.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 11:54:30 -0700 (PDT) Date: Thu, 5 Aug 2021 19:54:27 +0100 From: Lee Jones To: Greg Kroah-Hartman Subject: Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules Message-ID: References: <20210805075032.723037-1-lee.jones@linaro.org> <20210805075032.723037-2-lee.jones@linaro.org> <20210805173625.GH6719@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , linux-sh@vger.kernel.org, Catalin Marinas , Paul Walmsley , Sebastian Reichel , "James E . J . Bottomley" , Max Filippov , Guo Ren , linux-csky@vger.kernel.org, sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-riscv@lists.infradead.org, Will Deacon , Thomas Gleixner , Anton Ivanov , Jonas Bonn , linux-s390@vger.kernel.org, Brian Cain , Helge Deller , Ley Foon Tan , Christian Borntraeger , Ingo Molnar , Geert Uytterhoeven , linux-snps-arc@lists.infradead.org, Jeff Dike , uclinux-h8-devel@lists.sourceforge.jp, linux-xtensa@linux-xtensa.org, Albert Ou , Vasily Gorbik , Heiko Carstens , linux-um@lists.infradead.org, Stefan Kristiansson , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , John Crispin , Stafford Horne , linux-arm-kernel@lists.infradead.org, Chris Zankel , Michal Simek , Thomas Bogendoerfer , linux-mips@vger.kernel.org, Yoshinori Sato , linux-parisc@vger.kernel.org, Vineet Gupta , linux-kernel@vger.kernel.org, Palmer Dabbelt , Richard Weinberger , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 05 Aug 2021, Greg Kroah-Hartman wrote: > On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote: > > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote: > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > > index b4bb67f17a2ca..cf89ce91d7145 100644 > > > --- a/arch/arm64/kernel/process.c > > > +++ b/arch/arm64/kernel/process.c > > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd) > > > printk("Reboot failed -- System halted\n"); > > > while (1); > > > } > > > +EXPORT_SYMBOL(machine_restart); > > > > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general > > use by out of tree drivers and it matches the other pm_power_off symbol > > we export in this file. > > Yes please. Sure. Thanks for the feedback. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog