From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6346BC433EF for ; Sat, 6 Nov 2021 22:49:18 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B05A608FB for ; Sat, 6 Nov 2021 22:49:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5B05A608FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hmsxl2pKCz3c5B for ; Sun, 7 Nov 2021 09:49:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=h06/7/tP; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmx.net (client-ip=212.227.17.20; helo=mout.gmx.net; envelope-from=j.neuschaefer@gmx.net; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.a=rsa-sha256 header.s=badeba3b8450 header.b=h06/7/tP; dkim-atps=neutral X-Greylist: delayed 417 seconds by postgrey-1.36 at boromir; Sun, 07 Nov 2021 08:03:54 AEDT Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HmqcB143lz2xfD; Sun, 7 Nov 2021 08:03:53 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636232619; bh=Mwd00qb2ZiJx72AR8VOZy+k9pKeasCOoFRxt9I1uV2U=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=h06/7/tP0ZWy0v0n/bk0w+qqC3J4P5pP65h1+f+oMPKVhQ7gYJROQLFPhUArLsuuj sAdS9r2lqRD4xR5J9wfz8Nuf9AAycmie3qoF12y2qdKfqsvDs4MLp5uj60h+AMDeJQ sGOXwo0iyFk7+2Mwn6jTlgsknRg/s3x6lAVadLbg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from longitude ([87.79.195.52]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOA3F-1n7sEw3p2f-00OWCa; Sat, 06 Nov 2021 21:54:16 +0100 Date: Sat, 6 Nov 2021 21:54:06 +0100 From: Jonathan =?utf-8?Q?Neusch=C3=A4fer?= To: Dmitry Osipenko Subject: Re: [PATCH v2 27/45] mfd: ntxec: Use devm_register_power_handler() Message-ID: References: <20211027211715.12671-1-digetx@gmail.com> <20211027211715.12671-28-digetx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EIEte5+tjVxDHmE6" Content-Disposition: inline In-Reply-To: <20211027211715.12671-28-digetx@gmail.com> X-Provags-ID: V03:K1:SVFlmtuvvynO7MrtDzObaEyN/WaPcv8tOsGAlIRvdbuKBKDAEQ/ nVePqR5eYOMd9xdpGO5unEqHbls4MbMcwDHHiD/2xW054xRTDPzVuInIGVNwfhVnOpuaRe4 ac8qzmvsisWAHTSwATyyh2lQM4j3GTT+YgfTlnX+xnTkWWDcDQ1QJM/FLNOUp2gu+vKNebi 4PIdlh56euOWziRZzNIlQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:+q4twkx5HbQ=:c6NWW/lGyz+JrrEJOfeSU1 SbdM2xrm6euZgxRw7dVhrAaUHO1zelRx5cOKxQGxOMT7QAx66Da75vDzNqQCWWxDYOdojhDK1 DJAqQVrMPelTvzp/kb11dyJ6o9L2Z89wNvC/KaKDVRWw50xyWWy1LzeT5amKb/91ezYOhPts0 p6bdhlVzvn1pK8/164HGZf2/lM9lXB3/eWZvqZWFVeHX+obzdLGFnTl2Imzx2hAk6yJs7n0uo f3AWu3WY1gbQGdUDjYgfXiYEpcn8EjXPl+MfItXqGBMDx8YIGG734fW1T/DPqh8AVn0K2Kx9W TEGngW9+G57vuJWwQR374U91rnqlrAMFVMzRT+zgAXMkRAbSmyY8v4jpM+nQruDJ9wANa/0aK eu2SdgZeXdZMgXRv7cvfWzblWX3IwcMJag6Xo4AHIhG4MnASO4MG4SfufT7sGLFQP232taj02 ZtZrM89OqkaP2USIkav5fwKnU4K91mY0Glh+QCTYUJnyGlcj9QCRIBpqUs3DaY44H2jhtJ0r3 1xFhWcNhHUypIamywPWNeiJzkX232e1svbgoC0SSvGJpBeitpPIYOAUvklUQWVo7z5msOIAIf mzzEO8/o9Z39ZQdAdgzLvOzlg13TqWGOi9JNEAQUAXgfVN9V1dEx9hpdfiytfiBoziXwdqGaM A/Lg5tFCmIyyMiniDUDTQjfvKtkljS16AJqKvoYg7LAE0UI5Ws646b/yjuf7n5SRBoJtPI1IS 1NX6fdLstkTC5BY+OXOnwQDj5Sw2myqm39nuwA+ibmdIB1nBYQqozUBp3VqOAYO8p/zarwQZQ QLD6kChqUB2tOtZqHvPLDBQSfro+UyFvMZakRfSJn8R4/x4x7uGlaxRbVOglCOdenP+q0psnb xNr/MUWACDrWFi2qYGeo1Xm3jbvxVTU1xpmcsiPOb7z0uH385dbDNyZe647CScQHfzoAOK5l4 tSDRPqcwTz5ZiyV0RvknBXQdRbK0Sp815LiYolVqxBGF2+lnuDfXFDtm1nDpKpxUABeBa7Ov9 gd/QUJ9YsMbA0VAiOPRTc0TEJaiNPVMH89D2NeA2defW6th3cPpXvvcQOJtjGljchFaQqgZs4 gLk78skJYnmLNA= X-Mailman-Approved-At: Sun, 07 Nov 2021 09:48:37 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Rich Felker , linux-ia64@vger.kernel.org, Tomer Maimon , Santosh Shilimkar , "Rafael J . Wysocki" , Boris Ostrovsky , Catalin Marinas , Linus Walleij , Dave Hansen , x86@kernel.org, Tali Perry , Thierry Reding , Guo Ren , Pavel Machek , "H. Peter Anvin" , linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Greg Ungerer , Stefano Stabellini , Benjamin Fair , Yoshinori Sato , Krzysztof Kozlowski , linux-sh@vger.kernel.org, Lee Jones , Helge Deller , Daniel Lezcano , Russell King , linux-csky@vger.kernel.org, Jonathan Hunter , Tony Lindgren , Chen-Yu Tsai , Ingo Molnar , Geert Uytterhoeven , xen-devel@lists.xenproject.org, linux-mips@vger.kernel.org, Guenter Roeck , Len Brown , Albert Ou , linux-omap@vger.kernel.org, Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Vladimir Zapolskiy , linux-acpi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Mark Brown , Borislav Petkov , Greentime Hu , Paul Walmsley , linux-tegra@vger.kernel.org, Thomas Gleixner , Andy Shevchenko , Nancy Yuen , linux-arm-kernel@lists.infradead.org, Juergen Gross , Thomas Bogendoerfer , linux-parisc@vger.kernel.org, Nick Hu , Avi Fishman , Patrick Venture , linux-pm@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org, Palmer Dabbelt , Philipp Zabel , Paul Mackerras , Andrew Morton , linuxppc-dev@lists.ozlabs.org, openbmc@lists.ozlabs.org, Joshua Thompson Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --EIEte5+tjVxDHmE6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Oct 28, 2021 at 12:16:57AM +0300, Dmitry Osipenko wrote: > Use devm_register_power_handler() that replaces global pm_power_off > variable and allows to register multiple power-off handlers. It also > provides restart-handler support, i.e. all in one API. >=20 > Signed-off-by: Dmitry Osipenko > --- When I boot with (most of) this patchset applied, I get the warning at kernel/reboot.c:187: /* * Handler must have unique priority. Otherwise call order is * determined by registration order, which is unreliable. */ WARN_ON(!atomic_notifier_has_unique_priority(&restart_handler_list, nb)); As the NTXEC driver doesn't specify a priority, I think this is an issue to be fixed elsewhere. Other than that, it works and looks good, as far as I can tell. For this patch: Reviewed-by: Jonathan Neusch=C3=A4fer Tested-by: Jonathan Neusch=C3=A4fer Best regards, Jonathan --- Full Oops log: [ 3.523294] ------------[ cut here ]------------ [ 3.528193] WARNING: CPU: 0 PID: 1 at kernel/reboot.c:187 register_resta= rt_handler+0x4c/0x58 [ 3.536975] Modules linked in: [ 3.540312] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.15.0-00021-gcb24= c628b307 #622 [ 3.548214] Hardware name: Freescale i.MX50 (Device Tree Support) [ 3.554357] [] (unwind_backtrace) from [] (show_stac= k+0x10/0x14) [ 3.562183] [] (show_stack) from [] (dump_stack_lvl+= 0x58/0x70) [ 3.569824] [] (dump_stack_lvl) from [] (__warn+0xd4= /0x154) [ 3.577191] [] (__warn) from [] (warn_slowpath_fmt+0= x74/0xa8) [ 3.584727] [] (warn_slowpath_fmt) from [] (register= _restart_handler+0x4c/0x58) [ 3.593823] [] (register_restart_handler) from [] (_= _watchdog_register_device+0x13c/0x27c) [ 3.603889] [] (__watchdog_register_device) from [] = (watchdog_register_device+0x60/0xb4) [ 3.613764] [] (watchdog_register_device) from [] (d= evm_watchdog_register_device+0x3c/0x84) [ 3.623898] [] (devm_watchdog_register_device) from [] (imx2_wdt_probe+0x254/0x2ac) [ 3.633346] [] (imx2_wdt_probe) from [] (platform_pr= obe+0x58/0xb8) [ 3.641314] [] (platform_probe) from [] (call_driver= _probe+0x24/0x108) [ 3.649636] [] (call_driver_probe) from [] (really_p= robe.part.0+0xa8/0x358) [ 3.658384] [] (really_probe.part.0) from [] (__driv= er_probe_device+0x94/0x208) [ 3.667470] [] (__driver_probe_device) from [] (driv= er_probe_device+0x30/0xc8) [ 3.676468] [] (driver_probe_device) from [] (__driv= er_attach+0xe0/0x1c4) [ 3.685032] [] (__driver_attach) from [] (bus_for_ea= ch_dev+0x74/0xc0) [ 3.693253] [] (bus_for_each_dev) from [] (bus_add_d= river+0x100/0x208) [ 3.701563] [] (bus_add_driver) from [] (driver_regi= ster+0x88/0x118) [ 3.709696] [] (driver_register) from [] (__platform= _driver_probe+0x44/0xdc) [ 3.718522] [] (__platform_driver_probe) from [] (do= _one_initcall+0x78/0x388) [ 3.727444] [] (do_one_initcall) from [] (do_initcal= ls+0xcc/0x110) [ 3.735413] [] (do_initcalls) from [] (kernel_init_f= reeable+0x1ec/0x250) [ 3.743896] [] (kernel_init_freeable) from [] (kerne= l_init+0x10/0x128) [ 3.752224] [] (kernel_init) from [] (ret_from_fork+= 0x14/0x38) [ 3.759844] Exception stack(0xc40adfb0 to 0xc40adff8) [ 3.764933] dfa0: 00000000 00000000 = 00000000 00000000 [ 3.773143] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 = 00000000 00000000 [ 3.781351] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 3.788347] irq event stamp: 143613 [ 3.792102] hardirqs last enabled at (143623): [] __up_consol= e_sem+0x50/0x60 [ 3.800397] hardirqs last disabled at (143632): [] __up_consol= e_sem+0x3c/0x60 [ 3.808491] softirqs last enabled at (143612): [] __do_softir= q+0x2f8/0x5b0 [ 3.816591] softirqs last disabled at (143603): [] __irq_exit_= rcu+0x160/0x1d8 [ 3.825014] ---[ end trace 7f6709d2c89774b4 ]--- --EIEte5+tjVxDHmE6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmGG624ACgkQCDBEmo7z X9s6ChAAk6BAeo5fWoSSZHjjpn6ATqjK8ym6Qwe2EuauLkxbrtHK3OsbljBzCdtj p4LUnHOvUjWpnlBRfbbZSXKo5B0LxFtUhe/Cz9IDICft4K2DmOExc+xY9zQNcjMO rNIxDh4Q8qUdWv4c4B3p812s36yVKoaAGT6XHR9ISWOWmTWq/SNXiFetn9KdMaRs INw4aNL0grB717V8ucg5RtEOcrLEHRPf6Rv0b6yhfRdBQGx5XCatsdkofBcM9Rlr ECVr+SDk6hoMvPgqbnK3hh1fU0MGiDoyHN/+PhdW5k71EoqynneLlz1xhU4P1TAQ 4leH70X0lvTJSlpZ+dWkgVGkGzE8LtrjCwhCzZvf+UKqhKf4VWp9LInkiRU2mEaN ZGeaNLEL/oEE2nHZuWuW8imYr/WoYQKyZX+rG/g+aViMxom4/RC/IF5GFWxInCgi IBVFSiKxJOwKvKHZrsiJsk+zqcmb1TRObyYd0ecsOPD413IWwnFIl6502QRQolJH UvdIANNtt2/XORmBBNNGCQtZJ82srfxBpn9jzBtCZu03m4RymWvURbqbIx7mAiz0 6nj5cArubiCB8WOnOcCmsgHzLZDzN2SAy5UFxsELy67LUXWjsGMG++sHbkDuaiji /h71rvx5wmakG7quyBIQDCUtxgSMJL73yZA4N8UsQABCsmnNXgE= =jBJI -----END PGP SIGNATURE----- --EIEte5+tjVxDHmE6--